Download & Extend

Warning when no search results are returned

Project:Sphinx search
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When no search results are return the following warning occurs:-

warning: Missing argument 2 for sphinxsearch_help(), called in Z:\environment\www\sites\all\modules\sphinxsearch\sphinxsearch.pages.inc on line 73 and defined in Z:\environment\www\sites\all\modules\sphinxsearch\sphinxsearch.module on line 13.

Comments

#1

Looked further into this, the call to sphinxsearch_help($path, $arg) expects 2 arguments but in sphinxsearch.pages.inc on line 73
$output = theme('box', t('Your search yielded no results'), sphinxsearch_help('sphinxsearch#noresults')); only passes 1 argument.

#2

Status:active» needs review

Yep, use of drupal_help_arg() is missig here. Please, try this:

$output = theme('box', t('Your search yielded no results'), sphinxsearch_help('sphinxsearch#noresults', drupal_help_arg()));

PS: My daily job is keeping me busy enough these days, and I'm desperately trying to find a hole to finish the port to D6 and keep adding more features.

#3

Thanks. This fixes it.

#4

Status:needs review» reviewed & tested by the community

#5

Status:reviewed & tested by the community» closed (duplicate)

I'll be marking all issues related to D6 port of this module as dup of this one:

http://drupal.org/node/306959

I hope to get things fixed by this weekend.

#6

Status:closed (duplicate)» fixed

This should be fixed in new development snapshot that will be generated next midnight.

#7

Status:fixed» closed (fixed)
nobody click here