Unify all core package names to "Core"
Xano - October 9, 2008 - 11:20
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | Xano |
| Status: | closed |
Description
Since required Core modules aren't shown anymore displaying "Core - optional" is too much and it might be confusing (because where are the required modules then?). The attached patch changes the package from all optional Core modules from "Core - optional" to "Core". The required modules' package stays the same.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| core_package_00.patch | 15.35 KB | Ignored | None | None |
#1
Maybe it should be
package = Drupalinstead? Or evenpackage = Drupal core?#2
+1 for
package = Drupal core.By the way, should core be capitalised or not?
#3
Based on other text, no.
#4
This patch changes "Core - optional" to "Drupal core" and additionally "Core - required" to "Drupal core (required)". I think using brackets is better for readability than a dash.
#5
Looks nice but your system.module change is inserted in this patch file.
#6
Aaargh, I did a CVS update before creating the patch? :S
#7
Text change for package variable in info file is good.
#8
I was going to rtbc this but earnie beat me to it.
#9
This patch needed to change the string to hide the required group in admin/build/modules. Added the change to system.admin.inc from #6.
#10
Dave's addition is good. This is still RTBC.
#11
+1 for Dave's addition.
That package check could be done far better by using drupal_required_modules(), but that's something for another issue.
#12
Separate but related issue in #319699: Simplify required module hiding in admin/build/modules.
#13
We're going to fix the problem Dave mentioned in #9 in #319699: Simplify required module hiding in admin/build/modules.
The attached patch puts all core modules in the same, human readable package.
#14
Works and put all core modules into the same fieldset. Revised patch fixes the system module tests (fieldset used to enable/disable modules) and passes 100%!
#15
Patch in #14 applies cleanly, passes all tests, and is RTBC.
#16
#17
Shoot. Sorry guys, but we can't use "Drupal core" because of branded distros. http://drupal.org/node/81740#comment-443099 from the original package patch.
I agree that "Core - optional" is exceptionally silly now that Core required aren't shown. "Core" is fine, though. So could we get one that does "Core" and "Core (required)" ?
#18
Revised patch that changes all core modules package info to "Core." There is no longer a "Core - required" because of the new required module implementation in #319699: Simplify required module hiding in admin/build/modules.
#19
system.test's hunk needs work.
#20
Ah crap. Knew I shouldn't have done a grep for '= Drupal core'! System module test passes and confirmed the admin/build/modules screen appears as desired.
#21
Committed! :) Yay!
Now to look at that other eeeenteresting patch...
#22
Yay!
#23
.
I thought forks etc. weren't supported? On top of that: it is the actual Drupal Core those packages belong to.
#24
I think webchick means branded Drupals such as Acquia Drupal, not forks.
#25
Yeah. There are many ways to create a white-label distribution of Drupal that don't constitute "forking." For example, a university creating a distro of Drupal for all departments to create their own branded sub-sites. They would call the distro "Acme University Website Builder" not "Drupal." It's one of the reasons site_name is in a variable_get. We shouldn't hard-code the word "Drupal" in the interface.
#26
Isn't the name 'Drupal' used in a lot of strings too?
#27
Shouldn't be. If they are, they should be replaced with variable_get('site_name'). Separate issue, of course.
Can we let this one die now, so it quits bumping up in my "My issues" queue all the time? :)
#28
See this issue : #98905: Remove the word 'Drupal' from all user-facing stuff
#29
Automatically closed -- issue fixed for two weeks with no activity.