Since required Core modules aren't shown anymore displaying "Core - optional" is too much and it might be confusing (because where are the required modules then?). The attached patch changes the package from all optional Core modules from "Core - optional" to "Core". The required modules' package stays the same.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | core_package_7.patch | 20.41 KB | dave reid |
| #18 | core_package_6.patch | 20.43 KB | dave reid |
| #14 | core_package_05.patch | 20.66 KB | dave reid |
| #13 | core_package_04.patch | 18.49 KB | xano |
| #9 | core_package_03.patch | 19.09 KB | dave reid |
Comments
Comment #1
Anonymous (not verified) commentedMaybe it should be
package = Drupalinstead? Or evenpackage = Drupal core?Comment #2
xano+1 for
package = Drupal core.By the way, should core be capitalised or not?
Comment #3
Anonymous (not verified) commentedBased on other text, no.
Comment #4
xanoThis patch changes "Core - optional" to "Drupal core" and additionally "Core - required" to "Drupal core (required)". I think using brackets is better for readability than a dash.
Comment #5
Anonymous (not verified) commentedLooks nice but your system.module change is inserted in this patch file.
Comment #6
xanoAaargh, I did a CVS update before creating the patch? :S
Comment #7
Anonymous (not verified) commentedText change for package variable in info file is good.
Comment #8
catchI was going to rtbc this but earnie beat me to it.
Comment #9
dave reidThis patch needed to change the string to hide the required group in admin/build/modules. Added the change to system.admin.inc from #6.
Comment #10
Anonymous (not verified) commentedDave's addition is good. This is still RTBC.
Comment #11
xano+1 for Dave's addition.
That package check could be done far better by using drupal_required_modules(), but that's something for another issue.
Comment #12
dave reidSeparate but related issue in #319699: Simplify required module hiding in admin/build/modules.
Comment #13
xanoWe're going to fix the problem Dave mentioned in #9 in #319699: Simplify required module hiding in admin/build/modules.
The attached patch puts all core modules in the same, human readable package.
Comment #14
dave reidWorks and put all core modules into the same fieldset. Revised patch fixes the system module tests (fieldset used to enable/disable modules) and passes 100%!
Comment #15
dave reidPatch in #14 applies cleanly, passes all tests, and is RTBC.
Comment #16
xanoComment #17
webchickShoot. Sorry guys, but we can't use "Drupal core" because of branded distros. http://drupal.org/node/81740#comment-443099 from the original package patch.
I agree that "Core - optional" is exceptionally silly now that Core required aren't shown. "Core" is fine, though. So could we get one that does "Core" and "Core (required)" ?
Comment #18
dave reidRevised patch that changes all core modules package info to "Core." There is no longer a "Core - required" because of the new required module implementation in #319699: Simplify required module hiding in admin/build/modules.
Comment #19
webchicksystem.test's hunk needs work.
Comment #20
dave reidAh crap. Knew I shouldn't have done a grep for '= Drupal core'! System module test passes and confirmed the admin/build/modules screen appears as desired.
Comment #21
webchickCommitted! :) Yay!
Now to look at that other eeeenteresting patch...
Comment #22
dave reidYay!
Comment #23
xano.
I thought forks etc. weren't supported? On top of that: it is the actual Drupal Core those packages belong to.
Comment #24
dave reidI think webchick means branded Drupals such as Acquia Drupal, not forks.
Comment #25
webchickYeah. There are many ways to create a white-label distribution of Drupal that don't constitute "forking." For example, a university creating a distro of Drupal for all departments to create their own branded sub-sites. They would call the distro "Acme University Website Builder" not "Drupal." It's one of the reasons site_name is in a variable_get. We shouldn't hard-code the word "Drupal" in the interface.
Comment #26
xanoIsn't the name 'Drupal' used in a lot of strings too?
Comment #27
webchickShouldn't be. If they are, they should be replaced with variable_get('site_name'). Separate issue, of course.
Can we let this one die now, so it quits bumping up in my "My issues" queue all the time? :)
Comment #28
lilou commentedSee this issue : #98905: Remove the word 'Drupal' from interface
Comment #29
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #30
xano