Create an update function to import access settings from a Drupal 6 install

The difference between D6 Access rules and this module is that this module doesn't have the "Check rules" page where you can test username, email, and hostname rules.

I'll open a separate issue for this as a feature request (#1397268: Add ability to check rules).

Who wrote the update function that's commented out?

Just as a note to self,

From the hook_update_N documentation when referring to the second number:

This digit should be 0 for initial porting of your module to a new Drupal core API.

The update function should therefore be 7001 7000

@typhonius, are you sure it's not 7000?

mymodule_update_7000(): This is the required update for mymodule to run with Drupal core API 7.x when upgrading from Drupal core API 6.x.

@fiz - Yep you're right - no idea how I misread that!

Hi I uncommented the user_restrictions_update_7102
I threw PDO exception an error on running update.php due to faulty queries. But I fixed these and updated the code and it worked! So thanks for leaving it in there. (Note I hard coded the Access Rule type to 'mail' in the first query "SELECT COUNT(DISTINCT aid) FROM {access} WHERE type = 'mail'" as I only cared about these rule types... you could change this if you wanted. Updated code below:

function user_restrictions_update_7102(&$sandbox) {
  if (!isset($sandbox['progress']) && db_table_exists('access')) {
    $sandbox['progress'] = 0;
    $sandbox['current_aid'] = 0;
    $sandbox['max'] = db_query("SELECT COUNT(DISTINCT aid) FROM {access} WHERE type = 'mail'")->fetchField();
  }

  drupal_load('module', 'user_restrictions');

  if (!empty($sandbox['max'])) {
    $rules = db_select('access', 'access')
      ->fields('access')
      ->condition('aid', $sandbox['current_aid'], '>')
      ->orderBy('aid', 'ASC')
      ->execute();

    foreach ($rules as $rule) {
      db_merge('user_restrictions')
        ->key(array(
          'type' => $rule->type,
          'mask' => $rule->mask,
        ))
        ->fields(array('status' => $rule->status))
        ->execute();

      $sandbox['progress']++;
      $sandbox['current_aid'] = $rule->aid;
    }
  }
  $sandbox['#finished'] = (
    empty($sandbox['max']) ? 1 : ($sandbox['progress'] / $sandbox['max'])
  );
}

There is an official release now.

Here is a quick patch based on #9. I went ahead and let it have free reign on all types and included the status column.

Thanks for these, I'll review and hopefully get something in by later today.

I've committed this locally but I'm going to make some more additions before pushing.

• Remove hosts from the query so we only get username/mail masks (hosts are catered for in D7 core)
• The hook_update_N function will only work for people who already have the module enabled so we also need 'import' functionality so new users are able to import from the access table after installing.

Sounds good.

Untagging. We already imported settings for D7 D.o

Recent changes are in the most recent dev, allowing imports on both module upgrade and manually through the UI module.