Tab "Content Types" shows for all members

joewang - October 9, 2008 - 14:38
Project:Content Type Administration by Organic Group
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:paulbooker
Status:closed
Description

The tab supposedly only for group admins displays for all members at the top of the Group homepage.

I'm using the latest dev that was committed today.

#1

joewang - October 9, 2008 - 14:49

In addition, the tab shows up for all standard group content (not just designated group nodes)

#2

paulbooker - October 10, 2008 - 10:44

The "working" development release was only available for download from today (10th October) and your posts are from the (9th October) so it may be you are using the broken development release.

If you would confirm your using the latest release , ill then investigate you problem(s) later today.

Thanks for you help.

Paul

#3

joewang - October 10, 2008 - 11:39

I just grabbed the latest dev (10/10) and it's the same behavior.

#4

joewang - October 13, 2008 - 15:31

In the latest CVS, og_content_types_admin.module says:

<?php
function _og_content_type_admin_is_admin_access_callback($nid){
 
$group = node_load($nid);
 
//$return  = (isset($group->og_selective) && _og_content_type_admin_is_admin($group)) ? TRUE : FALSE;
 
return TRUE;
  return
$return;
}
?>

Is the code right here, or just for debugging? This probably causes the tab to show everywhere.

#5

joewang - October 13, 2008 - 16:35
Status:active» needs review

I think I fixed this by uncommenting your line and getting rid of return TRUE;

#6

paulbooker - October 14, 2008 - 14:56
Assigned to:Anonymous» paulbooker

looking into this now ...

#7

paulbooker - October 14, 2008 - 15:10
Status:needs review» fixed

Thanks Joe,

That modification was left over from migration work . I'll have the correct version committed by the end of the week.

Best, Paul

#8

paulbooker - October 15, 2008 - 11:11
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.