Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
dblog.module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
10 Oct 2008 at 05:10 UTC
Updated:
12 Mar 2010 at 15:30 UTC
Jump to comment: Most recent file
dblog_watchdog() already forces the use of the default database, but it does so by database switching. That is so last version. These days we can request the database directly.
While I was at it I also converted dblog_watchdog() to use a built Insert query. I did not convert the rest of the module to DBTNG yet, as there's some tricksy Select work going on for the admin page that is pending on #299267: Add "Extender" support to SELECT query builder to make the Select builder even more flexible.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 319401-followup.patch | 968 bytes | andypost |
| #2 | dbtng-dblog_default-1225284149.patch | 1.49 KB | hswong3i |
| #1 | dblog_default-1223882511.patch | 1.53 KB | hswong3i |
| dblog_default.patch | 1.4 KB | Crell |
Comments
Comment #1
hswong3i commentedCorrect some typing mistake.
Tested with MySQL and PostgreSQL, DBLog simpletest all pass. Should be RTBC. Maybe someone give a hand for it?
Comment #2
hswong3i commentedPatch reroll via CVS HEAD.
Comment #3
dries commentedCommitted to CVS HEAD. Thanks.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #5
andypostIf we insert into "default" database so delete should happen same way
Comment #6
dries commentedThat makes sense to me but let see if there are any objections.
Comment #7
Crell commentedIn practice I don't think #5 is strictly necessary, but it's good parallelism and I can think of no adverse effects. +1
Comment #8
dries commentedCommitted to CVS HEAD. Thanks!