PostgreSQL compatibility and module activation on site w/o comments
Alex_Tutubalin - October 10, 2008 - 06:51
| Project: | Comment Subscribe |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | zyxware |
| Status: | won't fix |
Jump to:
Description
1) Comment Subscribe module is not compatible to PostgreSQL due to heavy usage of MySQL-specific SQL code
* ifnull function (coalesce() in postgress)
* IF statements (CASE in Postgress)
* Concat function ( '||' operator in Postgres)
* UPDATE t1,t2,t3 set t1.f=... join t2 .. (should be replaced with update t1 ... where t1.field in (select from t2,t3)
2) Also, module activation produces an error due to incorrect sql code generated if no comments exists on site (on MySQL too)
Both problems are fixed in attached patch. MySQL code is not touched, new SQL statements added under if $GLOBALS['db_type'] == 'pgsql'
| Attachment | Size |
|---|---|
| comment_subscribe-pgsql.diff | 8.8 KB |
#1
Hi Alex_Tutubalin,
Thanks for your patch. We will integrate it with our code and will soon release it for community review.
Regards
zyxware
#2
Hi Alex_Tutubalin,
Thanks for your patch. We will integrate it with our code and will soon release it for community review.
Regards
zyxware
#3
DELETE FROM {z_commentsubscribe} WHERE cid = %d or instr(parents, '%s,')could easily be
DELETE FROM {z_commentsubscribe} WHERE cid = %d OR parents LIKE '%%%s%%'Both work as intended on all databases since LIKE is a SQL-99 standard.
#4
Hi all!
Is it going to be introduced to HEAD?
+Subscribing
#5
It has been decided to merge Comment Subscribe module with the Comment Notify module as both currently have the same set of functionalities. We have stopped our support here and will be providing our support at the Comment Notify issue queue. To help you seamlessly migrate to Comment Notify, we have provided an easy migration pathway using the last update - 6.x-1.4. Migration instructions are provided at the Comment Subscribe project home page . Once again thank you all for your wonderful support and contributions towards this module. See you all at the Comment Notify issue queue :-)