#cache = TRUE from SA 47

catch - October 10, 2008 - 08:43
Project:Drupal
Version:7.x-dev
Component:forms system
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

This is in 6.x, and applies to 7.x.

Patch has some failed hunks.

AttachmentSize
core7-csrf-cached-forms_0.patch4 KB

#1

Dave Reid - October 11, 2008 - 03:24
Status:needs work» needs review

Think I got it. Running all tests in the meantime...

AttachmentSize
SA-319466.patch 4.05 KB

#2

Dave Reid - October 11, 2008 - 03:40
Status:needs review» reviewed & tested by the community

Meh... form api, blog, and poll tests all passed. Rest of the suite is running.....so......slow, almost half done, but no errors so far.

#3

Dave Reid - October 11, 2008 - 04:04
Status:reviewed & tested by the community» needs work

Oh wait... had 1 fail:
File sites/default/files/simpletest/html-1.txt was allowed to be uploaded Other upload.test 121 UploadTestCase->testFilesFilter()

#4

webchick - October 11, 2008 - 04:14

Oh shoot. ;) So I shouldn't have committed #1, eh? ;)

I've been kind of lax running the tests tonight in the interest of getting caught-up SA-wise, so make sure that this doesn't happen with the patch reverse-applied. Could've been one of the other patches.

#5

Dave Reid - October 11, 2008 - 04:18
Status:needs work» reviewed & tested by the community

You're correct. It still fails without the patch. So looks like this is good to go.

#6

webchick - October 11, 2008 - 04:52
Status:reviewed & tested by the community» fixed

OK cool. :) Committed to HEAD. Thanks!

#7

Anonymous (not verified) - October 25, 2008 - 04:55
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.