Download & Extend
Issues

Remove unnecessary boolean ternary conditionals

Posted by Dave Reid on October 10, 2008 at 4:41pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:task
Priority:minor
Assigned:Dave Reid
Status:closed (fixed)

Issue Summary

Did a search for statements similar to expression ? TRUE : FALSE, and just replaced it with (bool) expression for simplicity.

Login or register to post comments

Comments

#1

Posted by Dave Reid on October 10, 2008 at 4:49pm
Title:Remove unnecessary true or false ternary conditionals» Remove unnecessary boolean ternary conditionals
Status:active» needs review

Patch replaces any condition ? TRUE : FALSE or condition ? FALSE : TRUE ternary conditionals. I did a search for condition ? 0 : 1 and similar, but I'm not sure if I should replace those. Having to cast a boolean result to an int seems more complex than using the ternary in those cases.

AttachmentSizeStatusTest resultOperations
ternary-booleans-319666-D7.patch5.48 KBIgnored: Check issue status.NoneNone

#2

Posted by earnie on October 13, 2008 at 12:37am
Status:needs review» needs work

This looks good. It contains some space clean-up which is under a different issue.

#3

Posted by Dries on October 29, 2008 at 10:09am
Status:needs work» fixed

Committed to CVS HEAD. Thanks.

--project followup subject--

Posted by Anonymous (not verified) on November 12, 2008 at 10:13am

Automatically closed -- issue fixed for two weeks with no activity.

#4

Posted by Anonymous (not verified) on November 12, 2008 at 10:23am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here