Remove unnecessary boolean ternary conditionals
Dave Reid - October 10, 2008 - 16:41
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | minor |
| Assigned: | Dave Reid |
| Status: | closed |
Description
Did a search for statements similar to expression ? TRUE : FALSE, and just replaced it with (bool) expression for simplicity.
#1
Patch replaces any condition ? TRUE : FALSE or condition ? FALSE : TRUE ternary conditionals. I did a search for condition ? 0 : 1 and similar, but I'm not sure if I should replace those. Having to cast a boolean result to an int seems more complex than using the ternary in those cases.
#2
This looks good. It contains some space clean-up which is under a different issue.
#3
Committed to CVS HEAD. Thanks.
--project followup subject--
Automatically closed -- issue fixed for two weeks with no activity.
#4
Automatically closed -- issue fixed for two weeks with no activity.