confirm_form needs to be polite with $form['#attributes']

cha0s - October 10, 2008 - 19:15
Project:Drupal
Version:7.x-dev
Component:forms system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

confirm_form() shouldn't assume that it is the only one on the form to set the '#attributes' element. Please merge the array instead of assigning it.

#1

cha0s - October 26, 2008 - 21:56

bump...

#2

Damien Tournoud - October 26, 2008 - 22:10
Version:6.x-dev» 7.x-dev

Why not suggesting a patch? It will have to be against the 7.x code base (HEAD tag in CVS).

Please read http://drupal.org/patch/create for more information.

#3

cha0s - October 27, 2008 - 07:39

Sure thing. After playing I realized we can just concat the string... which leads me to my next issue:

$form['#attributes']['class'] should be an array. What would I file that under, a feature request..?

AttachmentSize
system.module.confirm_form.attributes.patch 713 bytes
Testbed results
system.module.confirm_form.attributes.patchfailedFailed: Failed to apply patch. Detailed results

#4

Damien Tournoud - October 27, 2008 - 07:43
Status:active» needs review

@cha0s, let's open a task, if you are willing to take the lead on this.

#5

Anonymous (not verified) - November 13, 2008 - 04:10
Status:needs review» needs work

The last submitted patch failed testing.

 
 

Drupal is a registered trademark of Dries Buytaert.