Download & Extend
Issues

confirm_form needs to be polite with $form['#attributes']

Posted by cha0s on October 10, 2008 at 7:15pm
Project:Drupal core
Version:7.x-dev
Component:forms system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Novice

Issue Summary

confirm_form() shouldn't assume that it is the only one on the form to set the '#attributes' element. Please merge the array instead of assigning it.

Login or register to post comments

Comments

#1

Posted by cha0s on October 26, 2008 at 9:56pm

bump...

#2

Posted by Damien Tournoud on October 26, 2008 at 10:10pm
Version:6.x-dev» 7.x-dev

Why not suggesting a patch? It will have to be against the 7.x code base (HEAD tag in CVS).

Please read http://drupal.org/patch/create for more information.

#3

Posted by cha0s on October 27, 2008 at 7:39am

Sure thing. After playing I realized we can just concat the string... which leads me to my next issue:

$form['#attributes']['class'] should be an array. What would I file that under, a feature request..?

AttachmentSizeStatusTest resultOperations
system.module.confirm_form.attributes.patch713 bytesIdleFailed: Failed to apply patch.View details

#4

Posted by Damien Tournoud on October 27, 2008 at 7:43am
Status:active» needs review

@cha0s, let's open a task, if you are willing to take the lead on this.

#5

Posted by Anonymous (not verified) on November 13, 2008 at 4:10am
Status:needs review» needs work

The last submitted patch failed testing.

#6

Posted by casey on March 23, 2010 at 11:32am
Status:needs work» fixed

fixed for D7

http://api.drupal.org/api/function/confirm_form/7

#7

Posted by casey on March 23, 2010 at 11:34am
Status:fixed» needs work

Oops to quick of judgement; no its not.

Currently can't provide patches.

<?php
  $form['#attributes'] = array('class' => array('confirmation'));
?>

Should become

<?php
  $form['#attributes']['class'][] = 'confirmation';
?>

#8

Posted by adityakg on March 26, 2010 at 8:15pm

Hi, I am new here. I am trying to learn on how to apply patches :)

AttachmentSizeStatusTest resultOperations
system.module.patch634 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in system.module_1_0.patch.View details

#9

Posted by adityakg on March 26, 2010 at 8:23pm

I'm sorry for the previous not-working patch. The previous patch is patched from the 'modules/system' folder instead of drupal '.' folder. 2nd try:

AttachmentSizeStatusTest resultOperations
system.module.confirm-form.patch634 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in system.module.confirm-form.patch.View details

#10

Posted by adityakg on March 26, 2010 at 8:24pm
Status:needs work» needs review

#11

Posted by System Message on March 26, 2010 at 8:40pm
Status:needs review» needs work

The last submitted patch, system.module.confirm-form.patch, failed testing.

#12

Posted by adityakg on March 26, 2010 at 9:02pm
AttachmentSizeStatusTest resultOperations
system.module.confirm-form.patch664 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in system.module.confirm-form_0.patch.View details

#13

Posted by adityakg on March 26, 2010 at 9:02pm
Status:needs work» needs review

#14

Posted by System Message on March 26, 2010 at 9:20pm
Status:needs review» needs work

The last submitted patch, system.module.confirm-form.patch, failed testing.

#15

Posted by adityakg on March 26, 2010 at 10:10pm
Status:needs work» needs review

sorry for the spamming :(

AttachmentSizeStatusTest resultOperations
system.module.confirm-form.patch664 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in system.module.confirm-form_0_0.patch.View details

#16

Posted by System Message on March 26, 2010 at 11:10pm
Status:needs review» needs work

The last submitted patch, system.module.confirm-form.patch, failed testing.

#17

Posted by adityakg on March 27, 2010 at 2:06pm
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
system.module.confirm-form.patch647 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 19,009 pass(es).View details

#18

Posted by casey on March 27, 2010 at 3:04pm
Status:needs review» reviewed & tested by the community

Some trouble with windows style newlines I see, but you fixed that.

Patch is good to go.

#19

Posted by adityakg on March 27, 2010 at 4:17pm

#18: thanks! still getting a grip of it. so, sorry for the spamming :)

#20

Posted by Dries on March 28, 2010 at 11:54am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#21

Posted by System Message on April 11, 2010 at 12:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.