OpenID Attribute Exchange Module Updates

darren.ferguson - October 10, 2008 - 20:40
Project:OpenID Attribute Exchange Implementation
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I have altered the module for the UI portion today and how the internals work per sanduhrs and some modificiations per the security and how the module utilizes the menu system, with tags.

These patches are for the main files in the module and incorporate all other changes that i have posted in order to make utilizing it easier instead of checking all of the patches i have posted today and yesterday.

These patches provide the following:

1. Code per drupal module coding standards (as best i could, i am sure there are some pieces i have missed).
2. Added security to the module menu items for the user so that anonymous users could not see information.
3. Changed callbacks in the menu so they utilize drupal_get_form directly instead of a wrapper function for that.
4. Altered some menu paths to make them more the drupal way.
5. Added menu local task default for the openid ax as the manage persona screen.
6. Removed the copy form on manage persona and put a link for copying.
7. Copying allows you to specify the fields you wish to copy from the persona to the other persona so you do not copy all of the fields.
8. Utilize form_state redirect instead of drupal goto in the module.
9. On updating personas have modified the screen so it is using fieldsets to keep the data managable and not having submit buttons every 10 fields.
10. Removed the hidden fields for no value since we can retrieve this information in the submit handler.
11. Submit handler re-worked so it will only call db queries if it has too, otherwise it will not store the data.

There are other changes, but overall i think you will approve of them. If for some reason you do not or you believe the change needs to be altered please let me know and i will be happy to alter it.

I have the module running on our server and it is working correctly. Will now tackle the attribute exchange portion and determine which hooks are needed since we are also looking at taking he data from profile nodes instead of just the personas and having the persona fields mapped to the pertinent profile node.

Respectfully,
Darren Ferguson

AttachmentSize
openid_ax.install.patch24.24 KB
openid_ax.inc_.patch21.01 KB
openid_ax.module.patch5.91 KB
openid_ax.pages_.inc_.patch26.92 KB
 
 

Drupal is a registered trademark of Dries Buytaert.