Posted by akashihi on October 11, 2008 at 10:15am
Jump to:
| Project: | Lootz Item Filter |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | professorbikeybike |
| Status: | needs review |
Issue Summary
filter_settings was broken and didn't see they're own variables. Also there was no support for multiple input filters using lootz. So here is patch:
--- lootz.module.old 2008-05-03 23:11:08.000000000 +0300
+++ lootz.module 2008-10-11 13:12:12.000000000 +0300
@@ -28,7 +28,7 @@
case 'process':
return _lootz_filter_process($text, $format);
case 'settings' :
- return _lootz_filter_settings();
+ return _lootz_filter_settings($format);
}
}
@@ -172,18 +172,18 @@
/**
* Return settings form
*/
-function _lootz_filter_settings() {
+function _lootz_filter_settings($format) {
+ $form=array();
$form['lootz'] = array(
'#type' => 'fieldset',
- '#tree' => TRUE,
'#title' => t('Lootz Settings'),
'#collapsible' => TRUE,
);
- $form['lootz']['lootz_item_database'] = array(
+ $form['lootz']["lootz_item_database_$format"] = array(
'#type' => 'radios',
'#title' => t('Item Database'),
'#options' => _lootz_get_available_item_dbs(),
- '#default_value' => variable_get('lootz_item_database', 'wowdb'),
+ '#default_value' => variable_get("lootz_item_database_$format", 'wowdb'),
'#description' => t('The item lookup database to use'),
);
return $form;
Comments
#1
This module really won't work with multiple databases because when rendering content, there's no way to figure out which javascript files need to be attached to the page. Adding all available seems like overkill. (See lootz_init() for the issue I'm talking about.) Suggestions around this issue would be appreciated, but for now I'm going to leave it as a global setting.