Add flag icon theme selector
Freso - October 11, 2008 - 13:48
| Project: | Language Icons |
| Version: | 6.x-2.x-dev |
| Component: | Icon collection |
| Category: | feature request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | patch (to be ported) |
Description
See comments in #292865: famfamfam flag icons and #300307: Add glossy flag theme; the latter also has some code that needs to be reviewed for this issue.
Also, in addition to the above two issues, #304793: Add "flags3d" flag collection also links to a collection that might be wanted.
#1
Finally i found the time to split my prior patch. Also added some jquery magic to hide the custom setting boxes if custom is not selected. The patch doesn't require any db update and will not break an existing site on updating.
#2
Almost forgot. The current plain theme with its info file. Place into flags folder.
#3
#4
This patch still needs a proper review (I'm working on one, with a follow-up patch). Until that has happened, this should stay as "patch (code needs review)". Also, don't assign to yourself, unless you intend to take it upon yourself to get the fixed.
#5
Is there any problem with understanding what this code does? How much longer will your review take?
#6
Dude what's your frigging issue? This code has been working for half a year now, how god-darn screwed up is your sense of how responsible module maintainership works? So i have to fork the stupid module just because of your foolish stubborness, that's really great. Awesome.
#7
@eMPee584
Will you please move on, work on other modules, fork it if you please, or do whatever but please stop posting such comments to this module's queue?
I don't think we want patches (it doesn't matter to me whether they're good or not) if we need to read such crap.
#8
Yeah Jose you wouldn't care if someone is actively blocking something you worked on... you would just swallow any angermotions because of 10s of wasted hours. Sorry mate, but your perspective on this issue is kinda incomplete. I did what Frederik forced me to do - split up the patch - and fixed several open issues with this, and he is just laughing in my face. Out of good reasons i resisted from forking up to now and wasted my time waiting and dealing with this in a very polite manner. When i see him working on other patches and filing bugs actively but just ignoring my contributions to this module since more than six months, there is a point where enough is enough.
This issue was basically the reason why i proposed a somehow modified module development process, replacing individual maintainers by the swarm. Because with single persons there's just to many social crap issues going on, which actually hinders progress on code functionality and quality.
#9
Great Freso, I repeatedly made myself behave like a jerk because of your attitude. Now will this *ever* move in? From all FLOSS maintainers i've taken notice of you're by far the least open one. If all of Drupal would be 'maintained' by people like you, the code base would still be in a pre-4.7 state. The only reason i have not yet forked this module is because that is even more stupid than having to wait for half a year to see one's contribution end up in the repository.
If i ever meet you in person at DrupalCon or whatever, rest assured i'll challenge you - either for a fist fight, drinking contest or running sprint. Justice will be dealt, in one way or the other.
#10
This is not funny anymore. If you are not interested in moving this module forward, for the sake of more than 4000 users, please consider transferring maintainership to someone else.