I think the second text is not necesarry - if the file isn't there, then it's obviously not writable.

Comments

webchick’s picture

As stated in IRC:

webchick: dmitrig01: I disagree.
webchick: dmitrig01: Those are two steps.
webchick: dmitrig01: If it only tells me "The file doesn't exist" I have to re-load for it to tell me "Oh, and it's not writable either"

dmitrig01’s picture

It should say it in one message then. I think it's better to show it in two steps.

webchick’s picture

If that list is a "check list" then each thing in there should be a different step. It therefore makes sense for them to be two items, because they're two different steps.

Maybe all we need is to change the titles so they're not both "Settings file." How about "Settings file" and "Settings permissions"?

dave reid’s picture

+1 on the title change for the permissions check. That would be best.

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new1.32 KB

Patch changes the title to 'Settings permissions'

moshe weitzman’s picture

Status: Needs review » Needs work

Permissions and Settings are high profile words in our Admin page. This rename is not an improvement IMO. I think settings file is a good name.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new1.32 KB

How bout 'Settings file writable'?

catch’s picture

So I originally split these into two during the status report patch, and left them the same because I couldn't think of how to give them distinct names cleanly.

As long as people are happy with 'settings file' and 'settings file writable' - and don't think we need the first to be 'settings file exists' (which is as far as I got before I gave up) then I think this is RTBC.

keith.smith’s picture

IMO, "Settings file permissions" would work.

Anonymous’s picture

Status: Needs review » Needs work

Yes, "Settings file permissions" is better. The error message gives the clue that we need write permissions.

Bojhan’s picture

Am I the only one who thought, dmitrig his install page should look like described in http://drupal.org/node/281446 ? Which would communicate a user to also do step 2? Therefor eliminating the need for two of these boxes? Less is more, if we can clearly put it in one box - we should go for that.

dave reid’s picture

Status: Needs work » Closed (duplicate)