I think the second text is not necesarry - if the file isn't there, then it's obviously not writable.

| Comment | File | Size | Author |
|---|---|---|---|
| #7 | install-settings-permissions-1054836-D7.patch | 1.32 KB | dave reid |
| #5 | install-settings-permissions-1054836-D7.patch | 1.32 KB | dave reid |
Comments
Comment #1
webchickAs stated in IRC:
webchick: dmitrig01: I disagree.
webchick: dmitrig01: Those are two steps.
webchick: dmitrig01: If it only tells me "The file doesn't exist" I have to re-load for it to tell me "Oh, and it's not writable either"
Comment #2
dmitrig01 commentedIt should say it in one message then. I think it's better to show it in two steps.
Comment #3
webchickIf that list is a "check list" then each thing in there should be a different step. It therefore makes sense for them to be two items, because they're two different steps.
Maybe all we need is to change the titles so they're not both "Settings file." How about "Settings file" and "Settings permissions"?
Comment #4
dave reid+1 on the title change for the permissions check. That would be best.
Comment #5
dave reidPatch changes the title to 'Settings permissions'
Comment #6
moshe weitzman commentedPermissions and Settings are high profile words in our Admin page. This rename is not an improvement IMO. I think settings file is a good name.
Comment #7
dave reidHow bout 'Settings file writable'?
Comment #8
catchSo I originally split these into two during the status report patch, and left them the same because I couldn't think of how to give them distinct names cleanly.
As long as people are happy with 'settings file' and 'settings file writable' - and don't think we need the first to be 'settings file exists' (which is as far as I got before I gave up) then I think this is RTBC.
Comment #9
keith.smith commentedIMO, "Settings file permissions" would work.
Comment #10
Anonymous (not verified) commentedYes, "Settings file permissions" is better. The error message gives the clue that we need write permissions.
Comment #11
Bojhan commentedAm I the only one who thought, dmitrig his install page should look like described in http://drupal.org/node/281446 ? Which would communicate a user to also do step 2? Therefor eliminating the need for two of these boxes? Less is more, if we can clearly put it in one box - we should go for that.
Comment #12
dave reidMarking this as a duplicate of #352722: Conditionally show "settings.php not writable" error.