Modules without files[] in .info cause errors

Posted by Dave Reid on October 11, 2008 at 5:27pm

Issue Summary

If you have a contrib module for 7.x that doesn't provide the files[] array in it's .info file, and you enable that module, it causes errors in _registry_rebuild:
* notice: Undefined index: files in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
* warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
* notice: Undefined index: files in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
* warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.

Patch adds a default $info['files'] = array() to module_rebuild_cache. Patch will also mark the module as incompatible in admin/build/modules so the rouge module cannot be enabled, since it would never be useful as no module functions would be found in the registry.

Attachment	Size	Status	Test result	Operations
module-info-files-D7.patch	1.42 KB	Idle	Failed: Failed to apply patch.	View details

Comments

#1

Posted by moshe weitzman on October 12, 2008 at 2:18am

Status:

needs review

» reviewed & tested by the community

Nice. This removes some rather disconcerting error messages.

#2

Posted by webchick on October 12, 2008 at 2:52am

Status:

reviewed & tested by the community

» fixed

Yay! Thanks. :)

#3

Posted by Dave Reid on October 12, 2008 at 10:13am

Status:

fixed

» needs review

Follow-up patch that does the same check when everyone will be upgrading to D7 from D6!

Attachment	Size	Status	Test result	Operations
module-info-files-followup-D7.patch	708 bytes	Idle	Failed: Failed to install HEAD.	View details

#4

Posted by Dave Reid on October 12, 2008 at 3:37pm

Had a logic error.

Attachment	Size	Status	Test result	Operations
module-info-files-followup-D7.patch	687 bytes	Idle	Failed: Failed to install HEAD.	View details

#5

Posted by webchick on November 9, 2008 at 7:16am

Status:

needs review

» needs work

Macintosh-105:core webchick$ patch -p0 < module-info-files-followup-D7_0.patch
patching file update.php
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 512 with fuzz 1 (offset 1 line).

Could you give this a quick re-roll? I just stumbled across it again and it seems like a good idea. :) And now that it's actually possible to upgrade D6 => D7 we can even test it too. ;)