The attached patch moves the option for custom dates to the first place of the select lists, which makes the availability of this feature more obvious.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | custom_date_before.png | 59.33 KB | xano |
| #7 | custom-date_after.png | 60.07 KB | xano |
| #1 | custom_date_01.patch | 1.03 KB | xano |
| custom_date_00.patch | 1.06 KB | xano |
Comments
Comment #1
xanoAttached a slightly more readable patch.
Comment #3
lilou commentedSee: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476
Comment #4
catchMoving to UX queue, and can we have a screenshot?
Comment #5
xanoThe only difference is that the 'Custom format' option has been moved to the top of the select list to prevent it from being overlooked.
Comment #6
yoroy commentedAFAIK there is no 'select list' in node/add apart from the one in menu item settings, so it's still not clear what you are saying. So, can we have a screenshot please?
Also, can you tell us *why* you think this particular form should be more prominent?
Comment #7
xanoI never said I was talking about the node/add form. This is about Administer > Site configuration > Date and time. And why? To prevent the option form being overlooked. I know from several people that they simple didn't notice this option until somebody else told them it was there. The predefined formats kind of 'block' it from view.
Comment #8
catchfwiw, I was looking for this the other day, and it took me a while to find, so I think it makes sense putting it at the top. While it's an 'advanced' option, you can't do any harm in there either, and it's easy to back out and use one of the pre-defined formats.
Comment #9
yoroy commentedSee? screenshots help! :) Seems like a helpfull change to me.
Comment #10
dries commentedPutting it at the top helps but it is still not 100% -- if you listen to your gut feeling, you'll feel it is still somewhat awkward. I'm happy to commit this for now, but maybe we can think of an even better fix?
Comment #11
xanoWhat about dumping the select list and using a custom date field that accepts tokens that are automatically converted to PHP's date() syntax if the form is being saved? I think this would make everything simpler for most users. Those tokens are much more readable than date()'s syntax, but they do take up a lot more space:
dversus[day2digits], for instance. It's just an idea that popped in my mind just now.Comment #12
catchMuch bigger issues being dealt with, but IMO stella's patch at http://drupal.org/node/318008#comment-1192626 handles this issue quite well (the comment I linked to has screencasts) - which persuades me the custom option should move outside the select list altogether.
Comment #13
xanoIMO Stella's patch adds extra clutter. Dries is right, but after two months I still cannot come up with a better idea than my patch in #1.
Comment #14
drupal_was_my_past commentedFixed in #11623: Localize date formats.
Comment #15
xano