Project:Import Typepad / MoveableType
Version:6.x-1.0
Component:Code
Category:bug report
Priority:critical
Assigned:berenddeboer
Status:closed (fixed)

Issue Summary

I could not get the module to work under D6.

Seems that the menu_hook doesn't conform to proper D6 format, which makes me less than optimistic about the rest of the functionality working...

Comments

#1

Yeah, that's not the only thing broken. I spent a few hours making fixes, but I got stopped up on the author mappings. I just decided to use drupal 5 with the import_typepad module for 5.x. If that's an option, you can do it and upgrade to 6 after the import.

#2

Yeah, I just set up another install on d5, imported, and upgraded it to d6. Then I reinstalled and reconfigured all the modules I had set up the day before on my first d6 install. Awesome.

#3

This really shouldn't be marked as stable for D6.x It really doesn't work. Just tested in D6.9.

#4

Tested with v6.10 and as said before, it's not even close to work.
I get the following error when I enable the module:
warning: Missing argument 1 for import_typepad_menu() in /Users/myusername/Documents/www/drupal-6.10/sites/all/modules/import_typepad/import_typepad.module on line 24.
and nothing else after that.

Unfortunately, I don't have time at the moment to learn how Drupal modules work to fix it...

#5

Status:active» needs work

Here's a start on a fix for this. I ran the 6.x-2.x version through coder module, first to clean up all the syntax errors that it complained about, and then with the upgrade 5.x to 6.x checks turned on. It doesn't throw errors on admin/build/modules any more, but it still doesn't work, either. I'm out of time for the day, I'll take another stab at this when I have some time.

Micah

AttachmentSize
import_typepad.320335-5.patch 22.2 KB

#6

FWIW I used the 5.x version in a =D5.x sandbox and then upgraded core to 6.x.

Also:
The module expects to import into a content type called "blog". Any other name will prevent you from editing the nodes. For simplicity, I wiped out the other content types from the 5.x install.

Set up your Drupal categories in advance. Taxonomy CSV import/export worked for me.

Set up your users in advance, since the import module wants to map the Movable Type author to the Drupal author.

Tidy your markup tags and oddball ASCII characters in the export file, before you do the import.

Also in the export file, change PRIMARY CATEGORY: to CATEGORY:. Honestly, I don't know if this was necessary but it took less time to do that than to type this sentence.

Ignore the "ERROR 1 State = 5" thrown errors.

full report: http://www.marketingtechnician.com/blog/migrating-movable-type-drupal

#7

I spent sometime reworking the module so that it would work for Drupal 6. The attached patch works for me if using the upload a file option. I didn't test the server path option. I also added fields so admins could choose which content types and vocabularies to use (before it had to be "blog").

Sarah

AttachmentSize
import_typepad_6.patch 23.25 KB
import_typepad.zip 12.18 KB

#8

Thanks Sarah, and also for volunteering to maintain the module.

I bumped into this:

before Step 2:
Fatal error: Call to undefined function dsm() in /home/domain/public_html/sites/all/modules/import_typepad/import_typepad.module on line 138

and after clicking the Import button
Fatal error: Call to undefined function dsm() in /home/domain/public_html/sites/all/modules/import_typepad/import_typepad.module on line 235

I got around both by replacing dsm with drupal_set_message.

FWIW the author and category mapping didn't work.

#9

Thanks for the feedback. I caught the dsm (depends on Devel module) and removed them here. There's a better patch here. http://drupal.org/node/681752. I will take another look at the mapping.

#10

The attached patch fixes the taxonomy mapping issue.

AttachmentSize
import_typepad_011510.patch 32.53 KB

#11

Against which codebase should this patch be applied. The patch is against import_typepad.module dated 3 Oct 2008. None of the files in any of the releases seem to match this date (6.x-1.0, 6.x-1.x-dev and 6.x-2.x-dev). I tried the patch against each of the files, and none of them would take (hunk #2 always failed), and doing a manual, line-by-line update also fails. Is there a special place where I can find the base import_typepad.module against which I can apply this patch?

#12

Never mind. I hit save just as I figured I would try HEAD in CVS. Found the file and the patch applied. Ignore my previous post directly above.

#13

Thanks gorlov. Any feedback on the patched module would be appreciated.

#14

Hi Sarah,

Thanks for picking this up. I'm going to try my first Drupal site and am coming over from B2Evolution. I've got my post content in MovableType format and have been trying to get this plugin to work.

After a lengthy install of Xcode I got the HEAD file from the CVS and patched with import_typepad_01112010.patch. In that instance the Taxonomy bug existed that was highlighted. So I've just had a crack with import_typepad_011510.patch. What I get now is a failure on the Taxonomy check even though the content type is correct.

The message is "Your selected content type is not associated with your selected vocabulary. Please correct and try again."

Any idea what's wrong? Can you update your patch?

Thanks,

Greg

AttachmentSize
contentassocprob.jpg 63.56 KB

#15

Version:6.x-2.x-dev» master

Try the attached patch against HEAD. There was a bug that kept content types aside from "blog" from passing form validation.

AttachmentSize
import_typepad_01192010.patch 32.55 KB

#16

Still getting the same problem as before. It goes through to the import screen to map the taxonomy but the terms don't show.

Screenshot attached.

AttachmentSize
Screen-shot-2010-01-19-at-23.30.10.jpg 66.99 KB

#17

I think the attached patch will fix the problem.

AttachmentSize
import_typepad_01202010.patch 32.55 KB

#18

I tried using import_typepad_01202010.patch but got the same result as MrBrainz' screenshot

nodes imported fine, but no taxonomy.

I also got the longest bunch of php warnings ever. at least 4 lines for each of the 1200 imported nodes:

notice: Undefined index: CONVERT BREAKS: in /home/pp_web/modules/contrib/import_typepad/import_typepad.module on line 462.
notice: Undefined index: ALLOW PINGS: in /home/pp_web/modules/contrib/import_typepad/import_typepad.module on line 462.
notice: Undefined index: BASENAME: in /home/pp_web/modules/contrib/import_typepad/import_typepad.module on line 462.
notice: Undefined index: in /home/pp_web/modules/contrib/import_typepad/import_typepad.module on line 462.

plus more on some nodes:
notice: Undefined index: in /home/pp_web/sites/all/modules/contrib/import_typepad/import_typepad.module on line 462.notice: Undefined property: stdClass::$format in /home/pp_web/modules/node/node.module on line 1036.
notice: Undefined property: stdClass::$name in /home/pp_web/modules/blog/blog.module on line 124.
notice: Undefined property: stdClass::$uid in /home/pp_web/modules/blog/blog.module on line 125.
notice: Undefined property: stdClass::$name in /home/pp_web/modules/blog/blog.module on line 126.
notice: Undefined property: stdClass::$nid in /home/pp_web/modules/statistics/statistics.module on line 83.
notice: Undefined variable: statistics in /home/pp_web/modules/statistics/statistics.module on line 236.
notice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinnotice: Undefinned property: stdClass::$uid in /home/pp_web/includes/theme.inc on line 1604.notice: Undefined property: stdClass::$name in /home/pp_web/includes/theme.inc on line 1620.notice: Undefined index: sticky in /home/pp_web/sites/all/themes/contrib/zen/zen/template.php on line 188.
notice: Undefined index: uid in /home/pp_web/sites/all/themes/contrib/zen/zen/template.php on line 198.
notice: Undefined property: stdClass::$nid in /home/pp_web/sites/all/themes/shampton/node.tpl.php on line 51.

any help is appreciated...

#19

I tried applying the patch(es) but my hunks failed.

Sarah, could you kindly roll and post a zip of the patched module? Thanks for pushing this along!

#20

Sure. Attached!

AttachmentSize
import_typepad.zip 21.14 KB

#21

success! Categories match up, clean import.
+1 karma for Sarah.

#22

Title:Drupal 6 version doesn't appear to work. » 6.x-1.0 Release Doesn't Work

Nice work, sjancich; you're really cleaning things up! Are there plans to support importing tags as well as categories?

#23

Travis,

Do you mean being able to import tags across multiple vocabularies?

Sarah

#24

Sarah, I refer to the fact that MoveableType has two taxonomy vocabularies: categories and tags. When I tried your updated module I saw the ability to import categories but not tags. The 5.x version of the module is the same.

#25

Excellent! The version in #20 above worked perfectly for me with Drupal 6.15. Thanks so much for a great module.

#26

I've used #20 too, and it perfectly worked on Drupal 6.16.

#27

Category:bug report» feature request
Priority:critical» normal
Status:needs work» active

Is there a way to support field mappings for excerpt and body etc?? My whole entry seems to get put in the body...

#28

Category:feature request» bug report
Priority:normal» critical
Status:active» needs work

Changing settings back.

#29

#20 worked amazingly. Thanks so much!

#30

Any way to replace the non-functioning release 6.x-1.0 with the release in #20. There are still some tweaks/enhancements I'd like to contribute from there, but concerns me to have to build all of this against a parallel build of the module.

#31

All using patch from #20, please also view my patch here: http://drupal.org/node/810172

There's a slight bug where comment count was not getting updated correctly.

#32

I've #20 and #31 in a patch that can be cleanly applied to the downloadable 1.0 version.

AttachmentSize
import_typepad_20.patch 30.17 KB

#33

An even better version: this one adds import into a freetagging vocabulary.

AttachmentSize
import_typepad.patch 30.57 KB

#34

Version:master» 6.x-1.0
Assigned to:Anonymous» berenddeboer
Status:needs work» fixed

Release 1.1 is pending which includes patches.

Probably the latest release needs some more testing, but just shout if there are issues.

#35

Status:fixed» closed (fixed)