Download & Extend
Certificate login » Issues

Fails if site is on a non-standard HTTPS port

Posted by tony_cowderoy on October 12, 2008 at 8:43pm
Project:Certificate login
Version:6.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When running Certificate Login on a non-standard port, e.g. https://www.example.com:8443, the login fails because the form action URL is https://www.example.com/login when it should be https://www.example.com:8443.

Replacing $_SERVER['SERVER_NAME'] with $_SERVER['HTTP_HOST'] in line 97 of certificatelogin.module seems to fix this (at least on Debian etch with Apache 2).

Old version of line 97:

$form['#action'] = 'https://'.$_SERVER['SERVER_NAME'].'/'.$_SERVER['REQUEST_URI'];

New version of line 97:

$form['#action'] = 'https://'.$_SERVER['HTTP_HOST'].'/'.$_SERVER['REQUEST_URI'];

Login or register to post comments

Comments

#1

Posted by tony_cowderoy on October 12, 2008 at 8:45pm

Correction! The first sentence should read:

When running Certificate Login on a non-standard port, e.g. https://www.example.com:8443, the login fails because the form action URL is https://www.example.com/login when it should be https://www.example.com:8443/login

#2

Posted by flamingvan on October 15, 2008 at 3:36pm

Thanks for that, tony_cowderoy. I am going to make the changes soon and release new versions. Just a couple of work hurdles to get through first.

#3

Posted by flamingvan on December 1, 2008 at 3:53pm

Tony,
I've made the change. Getting CVS to work always seems to take the most time for me...
Thanks,
Moses

#4

Posted by tony_cowderoy on December 22, 2008 at 10:22pm

Thanks. I've just installed the new version and it seems to work just fine.
Tony

#5

Posted by tony_cowderoy on December 23, 2008 at 6:15pm

Oops! I wrote too soon. I must have been testing the wrong installation. It doesn't work.

You have changed:

$form['#action'] = 'https://'.$_SERVER['SERVER_NAME'].'/'.$_SERVER['REQUEST_URI'];

to

$form['#action'] = 'https://'.$_SERVER['SERVER_HOST'].'/'.$_SERVER['REQUEST_URI'];

In my PHP installation there is no such value as $_SERVER['SERVER_HOST'].

It should be:

$form['#action'] = 'https://'.$_SERVER['HTTP_HOST'].'/'.$_SERVER['REQUEST_URI'];

BTW, ISTR that I made exactly the same mistake when I first tried to fix it.

Tony

#6

Posted by flamingvan on December 29, 2008 at 5:47pm

All set. I totally do not get CVS. I finally got that updated but it always takes me forever. I installed tortoise and that helps a little I guess.

#7

Posted by flamingvan on March 4, 2009 at 4:11pm
Status:active» fixed

fixed

#8

Posted by System Message on March 18, 2009 at 4:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.