adding a "last edited" tag to submission line [#32036]

It would be nice to be able to toggle on/off a "last edited on _date_" tag to the end of the "submitted by _user_ on _date_" line at the top of nodes. Somewhere I found a hack for adding this (though not as a configurable option) to xtemplate themes, and recently adapted it to work with PHPTemplate. I'm not really a programmer and don't know how to do patch submissions, but here is what you need to change on the phptemplate.engine file:

1) Beginning around line 280 under "function phptemplate_node" insert this:

$last_edited = '';

if ($node->created != $node->changed)
{
$last_edited = t(' | Last edited on %a',
array('%a' => format_date($node->changed)));
}

2) Then just below the newly inserted code, change this:

$vars['submitted'] = t('Submitted by %a on %b.', array('%a' => format_name($node), '%b' => format_date($node->created)));
}

to this:

$vars['submitted'] = t('Submitted by %a on %b.', array('%a' => format_name($node), '%b' => format_date($node->created))) . $last_edited;
}

3) Voila! If your node has been edited after its original submission date, the submission line should now include a "last edited on _date_" segment.

Unfortunately, I couldn't find where I found this original hack for Xtemplate, so I can't credit the source. It required only slight modifications to work with PHPTemplate.

It would be nice to have this built into PHPTemplate as an option that could be toggled on or off via the theme config page.

Comment	File	Size	Author
#28	node_revision_9.patch	5.31 KB	shouchen
#25	node_revision_8.patch	5.94 KB	shouchen
#19	node_revision_7.patch	5.9 KB	shouchen
#15	node_revision_6.patch	4.16 KB	shouchen
#13	node_revision_5.patch	2.98 KB	shouchen
#12	node_revision_4.patch	3.84 KB	shouchen
#10	node_revision_3.patch	3.99 KB	shouchen
#8	node_revision_2.patch	3.67 KB	shouchen
#6	node_revision_1.patch	2.26 KB	shouchen
#4	node_revision_0.patch	3.67 KB	shouchen
#3	node_revision_gui_change.png	8.23 KB	shouchen
#2	node_revision.patch	3.67 KB	shouchen

Comments

Comment #1

morbus iff

they/them

commented 23 November 2005 at 12:44

Project:	PHPTemplate	» Drupal core
Version:		» x.y.z
Component:	Code	» theme system

PHPTemplate is part of core in 4.7. Moving.

Comment #2

shouchen commented 23 November 2005 at 19:00

Status:

Active

» Needs review

Status	File	Size
new	node_revision.patch	3.67 KB

Here is a patch that accomplishes everything you asked for, including the ability to toggle on and off the display of the "Last revised" time. I changed the term from "Last edited" to "Last revised" because the $node->changed is only updated when you create a new revision.

This is my first Drupal patch that actually changes the way the code functions. Take it easy on me....

-Steve

Comment #3

shouchen commented 23 November 2005 at 19:03

Status	File	Size
new	node_revision_gui_change.png	8.23 KB

Screen shot because of change to GUI

Comment #4

shouchen commented 29 November 2005 at 03:14

Status	File	Size
new	node_revision_0.patch	3.67 KB

Updated patch because system.module changed slightly today in HEAD.

Comment #5

shouchen commented 8 December 2005 at 18:27

Could this be considered for 4.7? The changes are very simple.

Comment #6

shouchen commented 9 December 2005 at 00:55

Status	File	Size
new	node_revision_1.patch	2.26 KB

Updated patch

Comment #7

rkerr commented 9 December 2005 at 00:55

I'd like to see this feature. Haven't tested the patch myself yet though :)

Comment #8

shouchen commented 9 December 2005 at 00:58

Status	File	Size
new	node_revision_2.patch	3.67 KB

PLEASE USE THIS PATCH INSTEAD OF THE ONE I UPLOADED A FEW MINUTES AGO

Comment #9

shouchen commented 19 December 2005 at 19:26

Drupal Developers,
Could we get this very simple, yet useful, feature into 4.7 before the release candidate is released and it is too late for new features?
Thanks... -Steve

Comment #10

shouchen commented 21 December 2005 at 14:55

Status	File	Size
new	node_revision_3.patch	3.99 KB

Updated patch to include recent change to node.module

Comment #11

shouchen commented 21 December 2005 at 15:04

Please also see http://drupal.org/node/41973

Comment #12

shouchen commented 21 December 2005 at 23:08

Status	File	Size
new	node_revision_4.patch	3.84 KB

Cleaner code in the modification to node.module

Comment #13

shouchen commented 22 December 2005 at 00:47

Status	File	Size
new	node_revision_5.patch	2.98 KB

Modification to node.module no longer needed, already committed to HEAD because of http://drupal.org/node/41973

Comment #14

Tobias Maier commented 22 December 2005 at 07:51

Status:

Needs review

» Needs work

I reviewed your code a little bit

here are my thoughts:

I dont like this part

+
+  $last_revised = '';
+
+  if (theme_get_setting('toggle_revision_info_' . $node->type) && ($node->changed != 0) && ($node->created != $node->changed))
+  {
+    $last_revised = t(' | Last revised on %a.',
+    array('%a' => format_date($node->changed)));
+  }

do it the way it is done for $taxonomy (under this piece of code)
means with else {}
looks better and is clearner

the ugliest thing is that: $last_revised = t(' | Last revised on %a.',
fist | is something which belongs to a theme
second what if I want to print the "last revised"-part on another place as the submitted-variable?
It would be much cleaner if you would insert a new variable

Comment #15

shouchen commented 22 December 2005 at 15:03

Status	File	Size
new	node_revision_6.patch	4.16 KB

Tobias,
I think I understand what you mean... please review my latest patch.
Thanks,
Steve

Comment #16

shouchen commented 22 December 2005 at 15:04

Status:

Needs work

» Needs review

Comment #17

shouchen commented 22 December 2005 at 15:42

This is only supported for PHPTemplate themes, but the options are displayed for all themes. Is that an issue? If so, how do I get around that?

Comment #18

shouchen commented 22 December 2005 at 16:20

Status:

Needs review

» Needs work

Should be easy enough to add to chameleon (XTemplate) theme... I'll work on that.

Comment #19

shouchen commented 23 December 2005 at 03:31

Status:

Needs work

» Needs review

Status	File	Size
new	node_revision_7.patch	5.9 KB

Now the patch also works with the chameleon theme. Please review... thanks!

Comment #20

shouchen commented 28 December 2005 at 23:31

Requesting code review, please. I think I've made all of the suggested changes. Thanks!

Comment #21

Crell commented 29 December 2005 at 00:21

Status:

Needs review

» Reviewed & tested by the community

Applies cleanly for me, does what it claims, doesn't seem to break anything for me. Sending this upstairs to the big people. :-)

Comment #22

shouchen commented 3 January 2006 at 19:29

Looks like the big people upstairs might not have noticed the delivery... :-)

Comment #23

shouchen commented 10 January 2006 at 20:15

Please consider this contribution for 4.7 -- thank you.

Comment #24

JPV commented 27 January 2006 at 05:40

Please consider adding this to 4.7! The lack of this drives me nuts (http://drupal.org/node/28434). I could not possibly care less when a node was created, I want to know the last time somone maintained (edited) it. I can't believe something so fundamantal is missing from such a great product. Am I just missing something? This patch seems to show I'm not, but...

Comment #25

shouchen commented 29 January 2006 at 21:01

Status	File	Size
new	node_revision_8.patch	5.94 KB

Updated patch file because of some recent changes to applicable files.

Comment #26

shouchen commented 8 February 2006 at 14:11

Please consider this feature for 4.7... thanks.

Comment #27

drumm

he/him

NY, US

commented 7 May 2006 at 01:17

Status:

Reviewed & tested by the community

» Needs work

I think the current "Display post information on" is more readable than "Post submission information display." The new setting should have a simple title to match.

Otherwise looks okay.

And it is not necessary to add useless comments every week.

Comment #28

shouchen commented 7 May 2006 at 02:57

Status:

Needs work

» Needs review

Status	File	Size
new	node_revision_9.patch	5.31 KB

drumm,

The code in system.module had changed somewhat since I first created the patch. I've updated the patch so it can be applied to the current CVS HEAD cleanly (and to DRUPAL-4-7 with some "fuzz" and "offsets"). I've also changed some of the wording per your suggestion. Please review - thanks! -Steve

Comment #29

Crell commented 28 January 2007 at 06:11

Version:	x.y.z	» 6.x-dev
Status:	Needs review	» Needs work

I'm fairly certain a patch this old would need to be redone, but I'd still like to see it make it in.

Comment #30

Freso commented 29 September 2007 at 23:13

Subscribing as I'll happily review the code when it gets updated, but I don't see meself having the time for this soonishly.

Comment #31

pancho

UTC+2 🇪🇺 EU

commented 4 February 2008 at 20:26

Version:

6.x-dev

» 7.x-dev

Damn, this would have been great! Still it's too late for new features. Let's make D7 the best Drupal ever... :)

Comment #32

lhtown commented 26 April 2009 at 00:53

Oh, I do hope something like this is going into Drupal 7! The ability to change "submitted on" to "last updated on" would be perfectly marvelous.

Comment #33

sun.core commented 20 February 2010 at 08:16

Version:

7.x-dev

» 8.x-dev

Comment #34

valthebald

Sofia

commented 15 December 2012 at 18:54

1. Probably current setting should be split to 3, not 2:
a) Display author
b) Display created date
c) Display updated date
2. Should variable_get() be replaced with CMI configuration?

Comment #35

joelpittet

he/him

English

Vancouver

commented 21 November 2015 at 01:06

Version:	8.0.x-dev	» 8.1.x-dev
Status:	Needs work	» Closed (works as designed)

This can be done using the theme_settings toggle still in D8. Very similar to the last patch.

Your node.html.twig template.

    {{ node.changedtime }}<br>
    {{ node.changedtime|format_date('small') }}<br>
    {{ 'Last revised at @date'|t({ '@date': node.changedtime|format_date('short') }) }}<br>

If you feel this feature would be helpful still please re-open for 8.1.x feature but I think we have enough that if this is needed contrib or custom module/theme could solve this in a snap.