From: http://groups.drupal.org/node/7731

I'm aware of at least hook_menu.module.

CommentFileSizeAuthor
#14 empty.patch0 bytesmikey_p
#6 rename_mock_menu_module_2.patch3.54 KBmikey_p
#2 rename_mock_menu_module_2.patch3.54 KBmikey_p
#1 rename_mock_menu_module.patch2.17 KBmikey_p

Comments

mikey_p’s picture

mikey_p commented
Status: Active » Needs review
StatusFileSize
new rename_mock_menu_module.patch2.17 KB

This renames hook_menu.module to menu_test.module to be consistent with other mock modules.

mikey_p’s picture

mikey_p commented
StatusFileSize
new rename_mock_menu_module_2.patch3.54 KB

I forgot to fakeadd the renamed files in the first patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review

I think this was failed inadvertently by the test bot when HEAD was broken.

Status: Needs review » Needs work

The last submitted patch failed testing.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new rename_mock_menu_module_2.patch3.54 KB

Same patch, but it is passing all tests on a fresh checkout of head here. Definitely no php syntax errors.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review

I tested this on the latest head, I can't duplicate the PHP syntax error that the testing bot gets. It patched cleanly and all the menu tests pass for me. Setting back to code needs review, and this should get a couple more reviews just to be sure.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I filed a patch with the testing bot invalid results in #343426: Getting "PHP syntax error" on valid patch with files added and removed.

mikey_p’s picture

mikey_p commented
Title: Need to rename mock modules to conform to coding standards. » Rename mock modules
Status: Needs work » Needs review

I've tested this again. I absolutely cannot recreate the failures.

Shortening the title to make it easier to read.

Status: Needs review » Needs work

The last submitted patch failed testing.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review

Setting back to needs review again.....

For the record the reference for changing the name is now at:
http://drupal.org/node/325974 and http://drupal.org/node/302577

mikey_p’s picture

mikey_p commented
StatusFileSize
new empty.patch0 bytes

in IRC, catch suggested including an empty patch to prevent re-testing.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review

Testing slave #8 failure.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.