Rename mock modules
mikey_p - October 12, 2008 - 21:50
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | tests |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
From: http://groups.drupal.org/node/7731
I'm aware of at least hook_menu.module.
#1
This renames hook_menu.module to menu_test.module to be consistent with other mock modules.
#2
I forgot to fakeadd the renamed files in the first patch.
#3
The last submitted patch failed testing.
#4
I think this was failed inadvertently by the test bot when HEAD was broken.
#5
The last submitted patch failed testing.
#6
Same patch, but it is passing all tests on a fresh checkout of head here. Definitely no php syntax errors.
#7
The last submitted patch failed testing.
#8
I tested this on the latest head, I can't duplicate the PHP syntax error that the testing bot gets. It patched cleanly and all the menu tests pass for me. Setting back to code needs review, and this should get a couple more reviews just to be sure.
#9
The last submitted patch failed testing.
#10
I filed a patch with the testing bot invalid results in #343426: Getting "PHP syntax error" on valid patch with files added and removed.
#11
I've tested this again. I absolutely cannot recreate the failures.
Shortening the title to make it easier to read.
#12
The last submitted patch failed testing.
#13
Setting back to needs review again.....
For the record the reference for changing the name is now at:
http://drupal.org/node/325974 and http://drupal.org/node/302577
#14
in IRC, catch suggested including an empty patch to prevent re-testing.
#15
The last submitted patch failed testing.
#16
Testing slave #8 failure.
#17
Committed to CVS HEAD. Thanks!
#18
Automatically closed -- issue fixed for two weeks with no activity.