Bug in node_load call in statistics_node_tracker [#32040]

In statistics.module at line 165 the following code

if ($node = node_load(arg(1))) {

should be

>
if ($node = node_load(array(nid => arg(1)))) {

to stop very bad implode errors in node.module when $cond is imploded in node_load at line 363 of node.module in drupal 4.6.3.

The same code is still there in HEAD, so I think the bug applies there too.

Comment	File	Size	Author
#1	statistics.module.node_load.patch	377 bytes	dopry

Comments

dopry commented 21 January 2006 at 06:19

Version:	4.6.3	» 4.7.0-beta3
Assigned:	Unassigned	» dopry

Status	File	Size
new	statistics.module.node_load.patch	377 bytes

Verified that it is fixed in 4.6.5...

made a patch against 4.7.0-beta3, seems like it should apply against head as well.

dopry commented 21 January 2006 at 06:20

Status:

Active

» Needs review

updating status.

moshe weitzman commented 25 January 2006 at 02:29

Status:

Needs review

» Closed (works as designed)

node_load() now accepts an integer in 4.7. AFAICT, there is no bug here. you seem to be using 4.7 statistics.module with a 4.6.x site?