Any plan to integrate with Popups?
gausarts - October 13, 2008 - 05:11
| Project: | CCK Field Privacy |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | CPyle |
| Status: | needs work |
Description
Hi,
I use popups.module and works well for confirmation or forms, or other custom links, and even fine with views edit and delete links, apart from the default integration with CCK administration. It can even pull out user_category as a single form, that is really great feature, I think. Also hearing that this cck_field_privacy module will integrate with Friendlist which is optionally suggesting popups.module, too.
So I'd like to know if it is possible to use popups instead of jquery impromptu? You know, it will save us another module since popups are simply more extended. Thanks
#1
I'll look into integrating this, for the 6.x branch. A patch to implement it would move it along faster, although it seems there's adequate documentation about the API that I should be able to figure it out.
#2
I've looked into this a little bit. It seems like the Popups API really should be used in place of impromptu, as it integrates better with Drupal standard coding processes and is becoming increasingly widely adopted.
A patch will not be difficult but will require a couple major changes in the way the select form works.
I think I'm going to take this on over the next week and see if I can get a patch up. It will be based on the 1.3 branch of Popups API to begin with.
At the same time the conversion to popups API is done, it might be good to update the padlock icons to something more indicative of what the current setting is (Private, friends only, public), as the popups API has settings to set an element to be updated with new information when the form is completed. I'll make a separate issue/patch for this when I get there.
#3
This is a patch that eliminates the jQuery Impromptu dependency and will instead use popups API if it is available.
The cck_field_privacy.js file is no longer needed.
#4
#5
CPyle - thank you for your work on this, it's greatly appreciated. I will try and review it ASAP, any help others can give in reviewing & testing would be a big help in pushing this forward.
Bryan O'Shea
Obsidian Design
#6
I was intentionally holding off on pushing new versions of this patch out until the work on User Relationships integration had been committed. Now that that is in, I will be looking into porting the patch to the newest dev.
The main thing to look out for is that the form is now not done through javascript at all. It will be a completely FAPI based form, with AHAH controlling any kind of complex behavior.