Download & Extend
Pathauto » Issues

Hiding of description on node form doesn't always work (jQuery compatibility)

Posted by Davy Van Den Bremt on October 13, 2008 at 6:17am
Project:Pathauto
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi, I've found the hiding of the description on the node form via jquery not always working.

I found this lie of code in pathauto.js

$("//#edit-path ~ div[@class=description]").hide(0);

Changing it to

$("#edit-path ~ div[@class=description]").hide(0);

gives more consistent results.
Login or register to post comments

Comments

#1

Posted by Davy Van Den Bremt on October 13, 2008 at 6:18am

lie should be line :)

#2

Posted by greggles on December 14, 2008 at 1:18am

Under what scenarios doesn't it work?

#3

Posted by greggles on December 14, 2008 at 1:35am

Also, this is fixed in 6.x, fwiw.

#4

Posted by Davy Van Den Bremt on December 14, 2008 at 8:42am

And why not in 5?

#5

Posted by greggles on December 14, 2008 at 3:47pm

I believe it was because it didn't work at all in 6.x where it works most of the time in 5.x.

Can you give an example where it won't work for 5.x?

#6

Posted by Davy Van Den Bremt on December 15, 2008 at 7:48am

See attached image.

Shouldn't the pathauto text

AttachmentSizeStatusTest resultOperations
Picture 1.png19.34 KBIgnored: Check issue status.NoneNone

#7

Posted by Davy Van Den Bremt on December 15, 2008 at 7:48am

See attached image.

AttachmentSizeStatusTest resultOperations
Picture 1.png19.34 KBIgnored: Check issue status.NoneNone

#8

Posted by greggles on December 15, 2008 at 4:25pm

I believe you that it's not happening. But I'd like to understand why before we change this. Nobody has reported this problem aside from you so I'm hesitant to change it (and perhaps break it). Is it because of a custom theme? A custom theme function that acts on the node form? Something else specific to your site? Or just a less common configuration like having several cck fields of a certain type.

#9

Posted by Davy Van Den Bremt on December 15, 2008 at 4:35pm

I'm using jquery update module. Maybe that's the culprit?

#10

Posted by Davy Van Den Bremt on December 15, 2008 at 4:37pm

I just checked on a few of my websites. And indeed jquery update seems to be causing this behavior.

#11

Posted by greggles on December 15, 2008 at 5:22pm

Great - good to know the real cause of this.

Here's a real patch. It seems to work fine on a stock version of jquery for 5.x so I feel like we should probably include this. I'd like to get another review but imagine that we won't :/

AttachmentSizeStatusTest resultOperations
320480_jquery_forward_compatible.patch1.35 KBIgnored: Check issue status.NoneNone

#12

Posted by Dave Reid on July 3, 2009 at 11:36pm
Status:needs review» reviewed & tested by the community

That looks good actually.

#13

Posted by Davy Van Den Bremt on August 24, 2009 at 5:59am

Looks good.

#14

Posted by greggles on February 10, 2010 at 8:53pm
Title:Hiding of description on node form doesn't always work» Hiding of description on node form doesn't always work (jQuery compatibility)
Status:reviewed & tested by the community» fixed

Alrighty - fixed http://drupal.org/cvs?commit=326968

Thanks guys!

#15

Posted by System Message on February 24, 2010 at 9:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here