Default language does not follow NOR gallery NOR Drupal settings

this bug stand is the _gallery_init() function:

  $params = array('embedUri' => $embedUri,
                  'embedPath' => $embedPath,
                  'relativeG2Path' => $relativeG2Path,
                  'loginRedirect' => url('user/login'),
                  'activeUserId' => $user->uid,
                  'activeLanguage' => $user->language,
                  'fullInit' => $full);

This piece of code set the gallery language getting the user language whether the visitor is logged in or not.
If not, $user->language retrieve a null string, which is not understood by Gallery as a right 'activeLanguage'.

we can put the following code instead of, to set the gallery language with the drupal default language

if ($user->uid==0) //this is a visitor
{
  $result = db_query('SELECT locale, name FROM {locales_meta} WHERE isdefault = 1'); //get drupal's default language
  $row = db_fetch_object($result);
  $lang = $row->locale;
}
else
{
  $lang = $user->language;
}

$params = array('embedUri' => $embedUri,
                'embedPath' => $embedPath,
                'relativeG2Path' => $relativeG2Path,
                'loginRedirect' => url('user/login'),
                'activeUserId' => $user->uid,
                'activeLanguage' => $lang,
                'fullInit' => $full);

hi,

This is not totally true. Since when I did my tests, I was logged in and not. The results where the same.

the stand-alone Gallery (http://www.salsamontreal.com/montrealsalsa/outils/gallery2/) appears to be in english (except the content you type in), isn't it ? Are you sure you enabled the french translation in gallery2 settings ?

I think that a fallback aproch would be better in this case, since I think the value you are talking about, the user locale language, is in Drupal only if the "profile" module is enable.

actually the 'locale' module is needed, not the 'profile' module

The code I posted may be bugprone if 'locale' module is not enabled. Here the fixed version:

  if ($user->uid==0 && module_exist('locale')) //this is a visitor
  {
    $result = db_query('SELECT locale, name FROM {locales_meta} WHERE isdefault = 1'); //get drupal's default language
    $row = db_fetch_object($result);
    $lang = $row->locale;
  }
  else
  {
    $lang = $user->language;
  }
  
  $params = array('embedUri' => $embedUri,
                  'embedPath' => $embedPath,
                  'relativeG2Path' => $relativeG2Path,
                  'loginRedirect' => url('user/login'),
                  'activeUserId' => $user->uid,
                  'activeLanguage' => $lang,
                  'fullInit' => $full);

Something like this would be more proactive, I think.

if ([get the user profile language now]) = null then
   if ([get the Drupal language now]) = null then
      [get the gallery default language]
   endif
endif

the only case when drupal default language can not be retrieve ([get the Drupal language now]) = null) is when 'locale' module is not enabled, which means that the webmaster did not use another language than english. So we do not have to set the gallery language (which is english too)

to summary, that's what my code does:
- if user is not defined and 'locale' module is enabled, set the gallery language according to the default language setting in drupal.
- if not, 2 cases :
- webmaster does not user another language than english, ('locale' module is not enabled), $lang will be set with a null string (gallery2 will provide the only installed language too: english)
- the user is defined, $lang will be set with $user->language

Is it right for you ?

Damien
ps : Forgive me, I'm not fluent in english

I have got the same problem here.

Drupal 4.6.3 with locale.module installed. Default lang ist German (de).
Gallery2 with default lang set to German, as well.

I already replaced the _gallery_init() code piece with the one posted above (#3). But it still doesnt
work. The language of gallery2 is always switched to english when I open it from drupal and stays
so until I manually reset gallery2 settings back to german.

Any ideas?

Regards, Thilo

hi,

alexandreracine> the _gallery_init is in gallery.module file

profix> can you give us your website url and provide us an demo account to have a look on the bug?

Sorry for my very delayed response to your messages!

@dpdev
I'm currently working on a new site and of course can provide you access to play with
my configuration! Tell me your email-adress (in case you still want to gain access) to
send the login information to. But you should read the rest of my posting before.

@all
I was able to figure out, that its not necessarily the gallery.module's code causing the
error. I used the following code to trace variables from the code.

  if ($user->uid==0 && module_exist('locale'))
  {
    $result = db_query('SELECT locale, name FROM {locales_meta} WHERE isdefault = 1');
    $row = db_fetch_object($result);
    $lang = $row->locale;
  } else {
    $lang = $user->language;
    //$lang = 'de';
  }
  
  // print variable's values) 
  trigger_error("language: $lang", E_USER_ERROR);
  
  $params = array('embedUri' => $embedUri, ...

Output of code piece above:
user error: language: in /www/htdocs/w005e099/modules/gallery.module on line 321.

It seems like $user->language is an empty variable. When setting $lang manually to
'de' (look above) all works fine. But why? Do you have any idea why this variable is empty?
I will try to find a clue, look through the locale.module, etc. in hope to reveal this secret ;)

I just examined my database and it seems like drupal does not fill the language field in table users,
when the user signs up with the default language. I put various language IDs in that field for testing
purposes and voila the gallery switched to according language.

-> the gallery module is works fine (but drupal or perhaps the locale.module does not)

The following piece of code extends the one posted above and checks $user->language. If its
empty (= user uses drupal's default language) get default language as you do for guests. It
seems to works with any tested combination of gallery+drupal languages. So try out this one:

  if ($user->uid==0 && module_exist('locale'))
  {
    $result = db_query('SELECT locale, name FROM {locales_meta} WHERE isdefault = 1');
    $row = db_fetch_object($result);
    $lang = $row->locale;
  } else {
    $lang = $user->language;
    if(empty($lang))
    {
      $result = db_query('SELECT locale, name FROM {locales_meta} WHERE isdefault = 1');
      $row = db_fetch_object($result);
      $lang = $row->locale;    
    }
  }
  
  $params = array('embedUri' => $embedUri,
                  'embedPath' => $embedPath,
                  'relativeG2Path' => $relativeG2Path,
                  'loginRedirect' => url('user/login'),
                  'activeUserId' => $user->uid,
                  'activeLanguage' => $lang,
                  'fullInit' => $full);

profix: I had the same problem here, and the code you posted in comment #11 does work perfectly as of now. Thanks!