Context sensitive translation issue in system module

hass - October 13, 2008 - 21:42
Project:Drupal
Version:7.x-dev
Component:system.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active (needs more info)
Description

The attached D6 and D7 patch fixes a context sensitive issue in system module.

AttachmentSize
D6_core_system_context_sensitive_bug_2008101301.patch2.35 KB
D7_core_system_context_sensitive_bug_2008101301.patch2.46 KB

#1

Damien Tournoud - October 13, 2008 - 21:55
Status:patch (code needs review)» patch (reviewed & tested by the community)

Looks great, thanks for all of us non english-speaking :)

#2

Dries - October 14, 2008 - 20:28
Status:patch (reviewed & tested by the community)» patch (code needs work)

Elsewhere in Drupal, we tend to use @module instead of @module_name. Can we reroll with such a change?

#3

hass - October 14, 2008 - 21:06
Status:patch (code needs work)» patch (code needs review)

re-roled with @module.

AttachmentSize
D6_core_system_context_sensitive_bug_2008101401.patch2.3 KB
D7_core_system_context_sensitive_bug_2008101401.patch2.41 KB

#4

drewish - October 16, 2008 - 16:18

looks like a simple enough change to me.

#5

Damien Tournoud - October 16, 2008 - 16:21
Status:patch (code needs review)» patch (reviewed & tested by the community)

Thanks hass.

#6

Dries - October 16, 2008 - 20:23
Status:patch (reviewed & tested by the community)» fixed

Committed to CVS HEAD and DRUPAL-6. Thanks!

#7

hass - October 16, 2008 - 21:24

THX :-)

#8

Pasqualle - October 19, 2008 - 18:04
Status:fixed» active (needs more info)

I understand that this is better than it was.
I just would like to know, why do we accept patches like this for D6? What is the policy on D6 string changes?

There could be many similar small fixes for D6, but the D6 is translated, and I think this patch just made more work for D6 translators and D6 users..

#9

arhak - October 27, 2008 - 18:52

subscribing

 
 

Drupal is a registered trademark of Dries Buytaert.