Views 2 Style Plugin

mfer - October 14, 2008 - 12:43
Project:Media RSS
Version:6.x-2.3
Component:Code
Category:feature request
Priority:normal
Assigned:Microbe
Status:closed
Description

How about making this as a Views 2 style plugin. It would make it so much more flexible.

#1

DanielTheViking - December 9, 2008 - 00:26

Second that.

#2

Microbe - December 10, 2008 - 13:28
Assigned to:Anonymous» Microbe

Ok seeing as there is multiple interest in this I will give it a go

#3

Microbe - December 10, 2008 - 20:47
Status:active» needs review

I have committed a new version to CVS that should run as Views 2 style plugin.

Please can you test it
Thanks

#4

guix - December 16, 2008 - 17:05

This is so great a few days ago I saw Drupal didn't embed medias and I was ready to code it myself. Today I just saw your module and it's perfect for me !

About the Views 2 style plugin, a first test showed me this problem : I'm getting a media file linked 6 times instead of just one. On the browser it shows only 1 time but in the page source it's 6 times.

#5

guix - December 16, 2008 - 17:06
Version:6.x-1.0» 6.x-2.1

Changing the Version to 6.x-2.1

#6

Microbe - December 16, 2008 - 17:42

There was an error in one of the loops which was running an if ( VAR == 'image' ) and was somehow returning true even when VAR didn't == 'image' should be fixed in 6.x-2.2

#7

guix - December 16, 2008 - 21:18
Version:6.x-2.1» 6.x-2.3

Wow you're responsive ! I'm still getting the image 6 times in the source code however, on 6.x-2.3. It's an image field and there are 3 versions made with imagecache (but the image appearing 6 times in the source code is the good one). Please find attached an exemple.

(also /admin/reports/updates thinks 6.x-2.2 is more recent than 2.3, is it normal ?)

AttachmentSize
mediarss-6times.txt 3.44 KB

#8

Microbe - December 16, 2008 - 21:33

Ah, oops! I fixed this for image module but not for imagefield same problem though replace line

if(module_exists('imagefield') && $item->type==$mediarsstype){

with
if(module_exists('imagefield') && $item->type==$mediarsstype && $mediarsstype!='0'){

I will commit it in next version after feedback from my other updates

#9

guix - December 16, 2008 - 21:54

Thanks a lot, it works now ! I think you can close that issue when you release the next version, and thanks again for the module !

#10

Microbe - December 18, 2008 - 00:28
Status:needs review» fixed

commited

#11

System Message - January 1, 2009 - 00:30
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.