How about making this as a Views 2 style plugin. It would make it so much more flexible.

CommentFileSizeAuthor
#7 mediarss-6times.txt3.44 KBguillaumeduveau

Comments

Leeteq’s picture

Second that.

Microbe’s picture

Assigned: Unassigned » Microbe

Ok seeing as there is multiple interest in this I will give it a go

Microbe’s picture

Status: Active » Needs review

I have committed a new version to CVS that should run as Views 2 style plugin.

Please can you test it
Thanks

guillaumeduveau’s picture

This is so great a few days ago I saw Drupal didn't embed medias and I was ready to code it myself. Today I just saw your module and it's perfect for me !

About the Views 2 style plugin, a first test showed me this problem : I'm getting a media file linked 6 times instead of just one. On the browser it shows only 1 time but in the page source it's 6 times.

guillaumeduveau’s picture

Version: 6.x-1.0 » 6.x-2.1

Changing the Version to 6.x-2.1

Microbe’s picture

There was an error in one of the loops which was running an if ( VAR == 'image' ) and was somehow returning true even when VAR didn't == 'image' should be fixed in 6.x-2.2

guillaumeduveau’s picture

Version: 6.x-2.1 » 6.x-2.3
StatusFileSize
new3.44 KB

Wow you're responsive ! I'm still getting the image 6 times in the source code however, on 6.x-2.3. It's an image field and there are 3 versions made with imagecache (but the image appearing 6 times in the source code is the good one). Please find attached an exemple.

(also /admin/reports/updates thinks 6.x-2.2 is more recent than 2.3, is it normal ?)

Microbe’s picture

Ah, oops! I fixed this for image module but not for imagefield same problem though replace line

if(module_exists('imagefield') && $item->type==$mediarsstype){

with

if(module_exists('imagefield') && $item->type==$mediarsstype && $mediarsstype!='0'){

I will commit it in next version after feedback from my other updates

guillaumeduveau’s picture

Thanks a lot, it works now ! I think you can close that issue when you release the next version, and thanks again for the module !

Microbe’s picture

Status: Needs review » Fixed

commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.