Closed (duplicate)
Project:
Drupal core
Version:
x.y.z
Component:
contact.module
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Sep 2005 at 16:02 UTC
Updated:
29 Dec 2005 at 15:44 UTC
There was an attempt to do a spam exploit on the Feedback module.
Contact needs to be checked for similar weaknesses.
Here are the details:
http://drupal.org/node/29927
Comments
Comment #1
dries commentedThe contact module checks the recipient's address using
valid_email_address(). Would that be enough, or can they exploit the other form fields?Comment #2
killes@www.drop.org commentedAll form fields can potentially be exploited.
Comment #3
kbahey commentedThe exploit relies on putting a newline, followed by a To:, Cc: or Bcc:
They do a Cc: to a certain address, which gathers info on where the exploits are, possibly for mass spam mailings later.
The solution for feedback was to issue a cryptic error (invalid data in field X) for possible exploits in any field.
It is a bit overzealous in that it does not check for a newline, but this is a sure way to prevent it, no matter what tricks they do.
Perhaps this should go into killes' mail.inc, and can be used to validate any data that is to be emailed. This way anyone using the common mail backend will get that validation for free?
The function that checks for that is like this:
Comment #4
killes@www.drop.org commentedWe need to investigate if this is still an issue. I am afraid it is. My mail.inc would have dealt with it, but since this did not make core, we need to find a solution for 4.7.
Comment #5
killes@www.drop.org commentedmarking a duplicate of http://drupal.org/node/34002