I've tried to use the 5.x module to upgrade l10n_server from Drupal 5 to Drupal 6. Well, it did find its tables, identified keys and all but the fields array was missing in action, so most of the schema structure generation was not done. I've looked into the code, and it looks like it does indeed skip non-core tables, when fields are inspected.

Well, while the .info file on the module says "The Schema module for Drupal 5 helps prepare modules for Drupal 6.", it did not really fulfill this description, since it did not allow me to export the generated schema for reuse in the Drupal 6 code.

I've applied the attached patch to fix the issue for me, and with that, all contrib tables were nicely exportable in the schema format. It was great to quickstart the migration to Drupal 6. This is obviously not a real suggestion for a fix, I am just pointing out the "source of error" for me so you can go and look.

CommentFileSizeAuthor
#1 SchemaWithoutPatch.jpg147.73 KBgábor hojtsy
contrib-tables-ignored.patch802 bytesgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new SchemaWithoutPatch.jpg147.73 KB

Here is how it "works" without the patch. With the patch, all works nice.

KingMoore’s picture

KingMoore commented
Status: Needs work » Reviewed & tested by the community

Tested and working. Without this patch schema module doesn't help much in converting D5 -> D6 modules.

smk-ka’s picture

smk-ka commented

What's worse is that without this patch a lot of PHP warnings are displayed. Patch is working as expected.

web360’s picture

web360 commented

Tested and working. Thanks for the patch!

jbrown’s picture

jbrown commented

excellent!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Critical

Bumping to critical, and confirmed this patch fixes things. I'm not sure why that commented code is there in the first place, but removing it does seem to be the solution. Thanks a ton, Gábor!

jbrown’s picture

jbrown commented

it is also discussed here: http://drupal.org/node/146862#comment-828818 and here: http://drupal.org/node/223952

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Reviewed & tested by the community » Fixed

I've committed this (blindly, since I don't have any active D5 environments, but I trust the community's judgement).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.