Closed (fixed)
Project:
Ubercart
Version:
5.x-1.6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Oct 2008 at 22:13 UTC
Updated:
25 Nov 2008 at 14:27 UTC
Jump to comment: Most recent file
place an order using COD payment method, look at the order as an admin, refresh the window, delivery date is replaces with 01/01/1970
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | ga_patch_uc_payment_01.txt | 675 bytes | ginc |
Comments
Comment #1
ginc commentedit seems to me that op "order-delete" get executed when someone looks at the order! we are developing a custom payment module for uc and i had the same bug there, when i removed the lines after case "order-delete", the bug disappeared, but i couldn't pinpoint the problem root yet.
Comment #2
Island Usurper commentedFound the problem. There's a missing
break;statement between the 'can_delete' and 'delete' cases in uc_payment_order(). If uc_payment thinks the order can be deleted, it therefore thinks it is being deleted and invokes the 'order-delete' op of the payment methods.Comment #3
ginc commentedcan you please submit a patch?
and i don't understand why the 'can_delete' and 'delete' cases in uc_payment_order() are considered when someone just look at the order???
Comment #4
Island Usurper commentedJust get version 1.5. There's lots of other good stuff there, too.
When you view an order, there's the possibility you may be shown a delete button. So Ubercart checks whether all of the various modules will allow you to delete it. If the order shouldn't be deleted, the link or button won't be shown. 'delete' shouldn't happen just because you look at an order, but 'can_delete' certainly should.
Comment #5
ginc commentednot fixed in 1.5, patch attached
Comment #6
rszrama commentedHmm... it looks like this was committed, just not for the 1.5 release. It should show up in the 1.6 either later this week or next week.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #8
pebosi commentedStill have this problem on the 1.6 Version
Comment #9
pebosi commentedComment #10
rszrama commentedThis is working fine in the 1.6 on the Livetest. I'd make sure your Payment Pack module actually got updated. If it's not working, please open a new issue, as this one is old and a little confused.