I think that the $criteria array that is passed into votingapi_select_results in the plus1_vote function is missing the "function" parameter, like plus1_get_score function sets.

We've migrated weighted votes from DrupalIt to Plus1 and so count is different than sum for us.

Thanks for the nice module.

CommentFileSizeAuthor
#3 plus1_retrieves_wrong_total_issue_321398_3.patch618 bytesvoxpelli

Comments

voxpelli’s picture

voxpelli commented

I can confirm this - it retrieved the wrong number when I voted but after a page refresh it showed the correct number. Seemed as if it conflicted with the Fivestar-module I already had tried out on the nodes.

cardentey’s picture

cardentey commented

¿Someone has solved this problem? thanks

voxpelli’s picture

voxpelli commented
Status: Active » Needs review
StatusFileSize
new plus1_retrieves_wrong_total_issue_321398_3.patch618 bytes

I have attached a patch that seems to solve this

Chill35’s picture

Chill35 commented

Voxpelli,

I will give that patch some quick testing and apply it today. Looking good.

I will not have the opportunity to test along side with another module that uses the Voting API. If this works, though, it means it does not break anything, and that's good enough for me.

Chill35’s picture

Chill35 commented
Status: Needs review » Fixed

Committed to the 2nd branch. Will be part of 6.x-2.5 release. Thank you again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.