Closed (fixed)
Project:
Signup
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
15 Oct 2008 at 06:02 UTC
Updated:
7 May 2011 at 03:48 UTC
Jump to comment: Most recent file
As I noted over at #47913-13: More themeability (point B), consider the following scenario:
Site only allows signups for privileged roles, not all authenticated users. Anonymous user visits a signup-enabled node, and sees "Please login or register to sign up for this event." They login as a regular authenticated user, redirect to this node, and now they see nothing about signups at all. Perhaps that login text stuff for anonymous users should be conditional on if the 'authenticated user' role has the 'signup for content' permission.
Thoughts? Should be a relatively easy patch once #47913 lands. Just want to get feedback before anyone writes the code. Of course, there will be a theme function for this, so sites can turn it off at the theme layer if they need, but it seems reasonable for the module to just do this itself, no?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 321463_no_signup_login_link.1.patch | 2.35 KB | dww |
Comments
Comment #1
dwwNow that #47913 is committed, here's a patch for this.
Comment #2
gregglesCore in 6.x does this kind of check. So, to the extent that you believe you should "do what core does" then yeah, it's good.
Comment #3
stborchertWorks and can be commited.
Comment #4
dwwCool, thanks for the reviews and tests, folks. I committed that to HEAD, and backported/committed to DRUPAL-5. I didn't get a chance to test the backport (I'm traveling this weekend and don't have my usual dev environment), so if anyone can try out DRUPAL-5 branch of signup on a test site, that'd be lovely. ;)
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.