Project:Comment notify
Version:7.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:greggles
Status:closed (fixed)

Issue Summary

I installed the comment_notify module on buytaert.net per http://buytaert.net/comment-notifications-via-email and found various small UI issues.



AttachmentSize
comment-notify-1.jpg56.42 KB
comment-notify-2.jpg26.43 KB
comment-notify-3.jpg19.58 KB

Comments

#1

Assigned to:Anonymous» greggles
Status:active» needs review

Thanks for the review, Dries. Screenshots and arrows makes it easy to know what you want fixed.

One of these was fixed in the dev version (the last extra dot) and in reviewing this myself I felt like the #description under the default state for anonymous is extraneous so I removed it. It also uses non-Drupal terminology (flag, anon).

AttachmentSize
322089_ui_inconsistencies.patch 6.89 KB

#2

Status:needs review» fixed

There was a small typo in the patch where I replaced an unnecessary . with an unnecessary ". Whoops.

I applied this to both 5.x and 6.x.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#4

Status:closed (fixed)» active

We should actually fix the perm as well as renaming it.

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/gmap/gmap_m...

#5

Status:active» fixed

And now fixed.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.