"Drigg Powered" Logo Disappears

coins - October 16, 2008 - 16:37
Project:Drigg
Version:5.x-1.9
Component:User interface
Category:bug report
Priority:normal
Assigned:philbar
Status:closed
Description

A minor bug I'm sure, but just tought I'd point it out :

In the bottom left corner where there is a "Drigg Powered" logo, on certain pages it does not show up and instead just shows a text link which says "Drigg".

Here it is reproduced on drigg.org :
Page with the logo : http://www.drigg.org/
Page where logo disappears : http://www.drigg.org/published/top24h

#1

alliax - October 18, 2008 - 07:40

I'm guessing that's because the img src is relative :
< img src="sites/www.drigg.org/themes/drigg_theme/img/drigg_80_15.gif" alt="Drigg" >

it should rather be absolute with the additional / at the start like this :

< img src="/sites/www.drigg.org/themes/drigg_theme/img/drigg_80_15.gif" alt="Drigg" >

#2

mercmobily - October 18, 2008 - 09:07

Hi,

It actually needs the Drupal function that returns the theme's directory. I am away at the moment... can you please look it up for me and send me some working code?
That would be awesome... I am taken 1000% by FriendList/OPENsocial/Etc. at the moment. Any extra help with Drigg would be awesome (although Drigg is in a code freeze that is lasting a little too long as well... :-( )

Merc.

#3

philbar - November 27, 2008 - 19:18

Related Topic in the Drupal support forum:
http://drupal.org/node/52520

#4

philbar - December 28, 2008 - 05:47
Status:active» reviewed & tested by the community

Change the following...
<a href="http://www.drigg-code.org"><img src="<?php print path_to_theme()?>/img/drigg_80_15.gif" alt="Drigg" /></a>

...to this:
<a href="http://www.drigg-code.org"><img src="<?php print $base_path . $directory .'/img/drigg_80_15.gif'; ?>" alt="Drigg" /></a>

in the footer div of page.tpl.php.

#5

philbar - June 4, 2009 - 05:26

This is a simple fix merc.

#6

mercmobily - June 4, 2009 - 11:26

Hi,

Phil, I don't get why path_to_theme() is not working... what does it contain, and what is it *supposed* to contain in a rendered page?
Are we just missing a leading "/" before path_to_theme()...?

Merc.

#7

philbar - June 5, 2009 - 19:37
Status:reviewed & tested by the community» fixed

Commit #221370 by philbar at 19:36

#8

philbar - June 5, 2009 - 19:39

Merc,

I committed it to the 6.x branch. Shouldn't we also fix bugs in 5.x? Or would you prefer to mark that branch as "Unsupported"?

#9

philbar - June 5, 2009 - 19:47
Assigned to:Anonymous» philbar

#10

mercmobily - June 6, 2009 - 02:00

Hi,

THANK YOU!

Hey, please make 10000% sure that things are 1000000% fixed when you commit. I am sure you did... but just in case :D

Philbar, with D7 coming up, I really think we should make it clear that we are concentrating on D6 now -- and let's get it done ASAP so that we can forget about the D5 version of the module. Few people are still using D5 now...

Bye,

Merc.

#11

mercmobily - June 18, 2009 - 07:40
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.