modified nodes not recognized

peggys mouse - October 16, 2008 - 21:40
Project:Notify by Views
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:matt2000
Status:postponed
Description

I have set up two views which are set to trigger notifications. Users who are subscribed to notifications receive email when one view is updated with new content but not the other.

I'm not sure if this helps, but the view which doesn't trigger notifications is a clone of the working view - the only difference is that the working one lists new nodes that are in the moderation queue (not published) and the view that doesn't send notifications is a list of content which is published but has been edited and now has the "Node revision: State" = "Under moderation". That state is provided by the Revision Moderation module. These edited nodes show up on the view page but no email is ever sent.

I'm doing this so that when users edit existing content, the original content remains published on the site while the revision goes into a queue. I'm trying to notify the editor that they need to approve/delete this new revision.

Removing one of the views from the notification settings did not fix this problem so it is not related to there being multiple views set to send notifications.

#1

matt2000 - October 17, 2008 - 23:54
Assigned to:Anonymous» matt2000

Like it's parent, notify module, this module is concerned only when a node is created, so it won't include nodes that were created before the last mailing to a user. I will reconsider whether it is prudent to allow modified nodes to be included. It's probably a reasonable expectation that any modified nodes specified by the view should be included.

There is also a bug related to the case where a single user receives notifications from more than one view. In hindsight, I see that this scenarios was not adequately considered in the design of this module. As time allows, I will work toward improvements.

#2

peggys mouse - October 21, 2008 - 21:22

thanks matt,

it would certainly be handy. is there an easy way for you to programmatically tell if a node is new to a view?

#3

peggys mouse - October 21, 2008 - 21:26
Title:One view sends notifications, the other doesn't.» modified nodes not recognized

changing title to reflect what appears to be the real issue.

#4

matt2000 - October 21, 2008 - 22:27
Status:active» postponed

No. Views don't carry any kind of 'history.' The only things I can look at is: When was this node created? When was it last modified? The problem is that is currently only looks at the creation timestamp, when in some cases, it might make sense for it to look at the modified timestamp. I need to do some re-structuring, and I'm short on time for this module for the foreseeable future, so I'm marking this issue 'postponed'. Sorry. You may need to look at subscriptions module if you need an immediate solution. Not sure if that will cover it.

#5

emdalton - February 9, 2009 - 17:37

Something that can work if you only want to be notified of new additions to a view is using RSS with RSS2email.

We'd like to be able to include views that have been modified in notifications, as well.

#6

peggys mouse - February 11, 2009 - 21:42

this was solved with the 'subscription' module in conjunction with the 'revision moderation' module.

 
 

Drupal is a registered trademark of Dries Buytaert.