the message is not shown above the sitemap. While the method 'site_map_help()' does return the right message. And is being called by Drupal.
Where and how to fix?

Regards,
TheYOSH

CommentFileSizeAuthor
#2 site_map_menu_without_locale.patch1020 byteslongwave

Comments

frjo’s picture

frjo commented
Assigned: Unassigned » frjo
Status: Active » Fixed

The locale variable has been renamed to language in Drupal 6, I had missed to change that. Committed to 6-dev.

Please try it out and report back here.

I just committed a function to have separate menus for each language also. Try that out also if you have any need for it. http://drupal.org/node/322307

Thanks for the bug report!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Fixed » Needs review
StatusFileSize
new site_map_menu_without_locale.patch1020 bytes

The change to site_map.admin.inc does not work if locale is not installed - the variable used on the admin page has no language suffix, but _site_map_menus() always adds the current language. The attached patch fixes this.

frjo’s picture

frjo commented
Status: Needs review » Postponed (maintainer needs more info)

On my local test site the current 6-dev version of site map works with both locale module turned off and turned on.

Please notice that you need to enter a new/separate message for when the locale module is inactive.

Make sure you have the latest 6-dev version and try it out.

site_map.admin.inc,v 1.1.2.4
site_map.module,v 1.39.2.6

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed (maintainer needs more info) » Active

I am using the latest 6.x-dev version. This isn't related to the help message at the top, but the menu output (but it was caused by the commit mentioned in comment 1). On an English language site without locale enabled, the "Menus to include in the site map" admin menu item saves a variable called "site_map_show_menus", but _site_map_menus() looks for a variable called "site_map_show_menusen". This means that no menus are ever displayed on the sitemap page if the locale module is disabled.

frjo’s picture

frjo commented

Sorry, I misread you post. I have now committed a fix for this to 6-dev.

site_map.admin.inc,v 1.1.2.5
site_map.module,v 1.39.2.7

Please check it out and report back here.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Fixed

This fix solves my issue, thanks.

theyosh’s picture

theyosh commented
Status: Fixed » Needs work

Hi, sorry but _NO_ fix!

I have _NOT_ installed locale. And I don't wan't to. If you have local first installed and than turned off... that is not the same as never installed it. Because when you install a module, there are database changes. And not they are not always cleaned up when you disable a module.
I still see no message above my sitemap.....

I only show the navigation part of the site. But that should not have any influence about it. Because it is a predefined message which should be shown always.

Is there a way that I can send you debug info? What information do you need?

Regards,
TheYOSH

frjo’s picture

frjo commented
Priority: Critical » Normal
Status: Needs work » Postponed (maintainer needs more info)

theyosh, do I understand correctly that you have the latest versin of 6-dev

site_map.admin.inc,v 1.1.2.5
site_map.module,v 1.39.2.8

You have entered a "Site map message" at admin/settings/sitemap.

But when you view your site map the message is not displayed at the top of the page?

theyosh’s picture

theyosh commented
Status: Postponed (maintainer needs more info) » Fixed

Hi,

sorry my mistake. It was a problem in my theme. The $help var was not shown. I thought that the message text should been in the $content var and not in the $help var.

So the problem is fixed. Probably already a wile ago. Just thought about that it could be something in my theme.

But thanks a lot!

TheYOSH

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.