Originally reported by cha0s, on the IRC: $mode is a bitmask, not a boolean.

CommentFileSizeAuthor
#2 file-check-directory-mode-d6-2.patch18.69 KBdamien tournoud
file-check-permission-mode-d6.patch1.08 KBdamien tournoud
file-check-permission-mode-d7.patch1.3 KBdamien tournoud

Comments

drewish’s picture

drewish commented
Status: Needs review » Reviewed & tested by the community

speaking as the author of the patch that first called this a boolean, i can admit that yes it's a bug ;)

the D7 version is RTBC.

that said since we're making changes to the D6 version, i think we should also backport the comments to the FILE_CREATE_DIRECTORY and FILE_MODIFY_PERMISSIONS constants.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new file-check-directory-mode-d6-2.patch18.69 KB

Here is a D6 version, with an extensive port of Drewish doc revamp of D7.

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

I've committed the D7 patch, but I'll leave the D6 patch for Gabor to review. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

This is a great docs improvement for Drupal 6, so developers can better understand what is going on. However there are two slight problems, which IMHO should not be in the patch, while we are fixing docs layout and formatting problems as well:

- The "Check that the file's size is below certain limits." docs and things around that line are badly indented
- Text around "This is a powerful function that in many ways" is quite badly broken on newlines.

Not sure if these also apply to Drupal 7, in which case these should also be fixed there. Otherwise just do a quick update of this patch and it will get committed in due course.

dpearcefl’s picture

dpearcefl commented

Is this patch still needed for D6?

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.