Anyone else getting the right sidebar printed out when nothing is there?

td.right should not be printed out unless there is a block being printed out inside it. It should show the entire page instead, without the sidebar. Perhaps we need to add the regions into the template.php file.

Comments

matt v.’s picture

matt v. commented

I'd welcome a patch on this issue, if anyone cares to work on it.

darkmusic’s picture

darkmusic commented

well i noticed i was having this problem in the 6.x version anyways so i figured out what needs to be changed in the page.tpl.php file.

change:

             <td class="right">
              <div class="padding">
                <div class="moduletable">
                <?php if ($left || $right): ?>
                    <div id="sidebar-right" class="column sidebar">
                      <?php if ($secondary_links): ?>
                        <div id="secondary" class="clear-block">
                          <?php print theme('links', $secondary_links, array('class' => 'links secondary-links')) ?>
                        </div>
                      <?php endif; ?>
                      <?php if ($left) {  print $left; } ?>
                      <?php if ($right) { print $right; } ?>
                    </div> <!-- /sidebar-right -->
                    <?php endif; ?>
                </div>
              </div>
            </td>

to:

		<?php if ($left || $right): ?>
            <td class="right">
              <div class="padding">
                <div class="moduletable">
                    <div id="sidebar-right" class="column sidebar">
                      <?php if ($secondary_links): ?>
                        <div id="secondary" class="clear-block">
                          <?php print theme('links', $secondary_links, array('class' => 'links secondary-links')) ?>
                        </div>
                      <?php endif; ?>
                      <?php if ($left) {  print $left; } ?>
                      <?php if ($right) { print $right; } ?>
                    </div> <!-- /sidebar-right -->
                </div>
              </div>
            </td>
		<?php endif; ?>

notice that the if ($left || $right): (and its closing tag) is now outside the entire table cell. it works for me!

matt v.’s picture

matt v. commented
Status: Active » Fixed

darkmusic,

Thanks for the fix. I've now committed that update.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.