I applied De Morgan rules twice to theme.inc.

CommentFileSizeAuthor
#7 323182-theme-cleanup.patch788 bytesdamien tournoud
theme_cleanup.patch622 byteschx

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Confirmed logic is good.

damien tournoud’s picture

damien tournoud commented

That's a great patch... the second version hurts my eyes less.

dvessel’s picture

dvessel commented

Who in their right mind would write such logic? Heh. ;)

Thanks for the cleanup chx.

keith.smith’s picture

keith.smith commented
Title: Trivial simplifcation » Trivial simplification
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Ola! Committed to CVS HEAD. Thanks.

dries’s picture

dries commented
Status: Fixed » Needs work

Rolled back. The patch gives a parse error.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 323182-theme-cleanup.patch788 bytes

Note to self: always test patches.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Yeah...matching parenthesis are always good... Patch applies cleanly and doesn't fail at PHP parsing. :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.