Trivial simplification

chx - October 19, 2008 - 01:10
Project:Drupal
Version:7.x-dev
Component:theme system
Category:bug report
Priority:normal
Assigned:chx
Status:closed
Description

I applied De Morgan rules twice to theme.inc.

AttachmentSize
theme_cleanup.patch622 bytes

#1

Dave Reid - October 19, 2008 - 02:32

Confirmed logic is good.

#2

Damien Tournoud - October 19, 2008 - 10:37

That's a great patch... the second version hurts my eyes less.

#3

dvessel - October 19, 2008 - 18:12

Who in their right mind would write such logic? Heh. ;)

Thanks for the cleanup chx.

#4

keith.smith - October 19, 2008 - 18:16
Title:Trivial simplifcation» Trivial simplification

#5

Dries - October 19, 2008 - 20:07
Status:reviewed & tested by the community» fixed

Ola! Committed to CVS HEAD. Thanks.

#6

Dries - October 19, 2008 - 20:33
Status:fixed» needs work

Rolled back. The patch gives a parse error.

#7

Damien Tournoud - October 19, 2008 - 20:37
Status:needs work» needs review

Note to self: always test patches.

AttachmentSize
323182-theme-cleanup.patch 788 bytes

#8

Dave Reid - October 19, 2008 - 22:13
Status:needs review» reviewed & tested by the community

Yeah...matching parenthesis are always good... Patch applies cleanly and doesn't fail at PHP parsing. :)

#9

Dries - October 20, 2008 - 11:34
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#10

Anonymous (not verified) - November 3, 2008 - 11:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.