Download & Extend
Issues

Trivial simplification

Posted by chx on October 19, 2008 at 1:10am
Project:Drupal core
Version:7.x-dev
Component:theme system
Category:bug report
Priority:normal
Assigned:chx
Status:closed (fixed)

Issue Summary

I applied De Morgan rules twice to theme.inc.

AttachmentSizeStatusTest resultOperations
theme_cleanup.patch622 bytesIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by Dave Reid on October 19, 2008 at 2:32am

Confirmed logic is good.

#2

Posted by Damien Tournoud on October 19, 2008 at 10:37am

That's a great patch... the second version hurts my eyes less.

#3

Posted by dvessel on October 19, 2008 at 6:12pm

Who in their right mind would write such logic? Heh. ;)

Thanks for the cleanup chx.

#4

Posted by keith.smith on October 19, 2008 at 6:16pm
Title:Trivial simplifcation» Trivial simplification

#5

Posted by Dries on October 19, 2008 at 8:07pm
Status:reviewed & tested by the community» fixed

Ola! Committed to CVS HEAD. Thanks.

#6

Posted by Dries on October 19, 2008 at 8:33pm
Status:fixed» needs work

Rolled back. The patch gives a parse error.

#7

Posted by Damien Tournoud on October 19, 2008 at 8:37pm
Status:needs work» needs review

Note to self: always test patches.

AttachmentSizeStatusTest resultOperations
323182-theme-cleanup.patch788 bytesIgnored: Check issue status.NoneNone

#8

Posted by Dave Reid on October 19, 2008 at 10:13pm
Status:needs review» reviewed & tested by the community

Yeah...matching parenthesis are always good... Patch applies cleanly and doesn't fail at PHP parsing. :)

#9

Posted by Dries on October 20, 2008 at 11:34am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#10

Posted by Anonymous (not verified) on November 3, 2008 at 11:41am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.