Posted by jenlampton on October 19, 2008 at 5:55am
Jump to:
| Project: | Nodewords: D6 Meta Tags |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Entering values into TD.title didn't actually change the page title. I found, when examining nodewords/metatags/DC.Title.inc (why its capitalized, I have no idea) that the function nodewords_dc_title_prepeare only accounted for what to do when a DC.Title was NOT supplied by the user. The first if was never followed up by an else:
if (!isset($value) || empty($value)) {I added the following else, and moved the return $value below it.
else {
// what if it was actually provided?
$value .= ' - ' . variable_get('site_name', 'Drupal');
}
return $value;patch attached.
Jen
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| dc_title_else.patch | 503 bytes | Ignored: Check issue status. | None | None |
Comments
#1
This works fine for me too! Please commit it.
#2
As the Drupal 5 version is not supported anymore, I am changing the status of this report.
#3
Is this solved in D6 already?
#4
Settings the DC.Title doesn't change the page title, because the DC.Title meta tag is not though to replace the page title (which is the one set in the title tag), but to suggest an alternative title to the search engines that actually use it.
#5
#6
Automatically closed -- issue fixed for 2 weeks with no activity.