Hidden variables in the system's send email and messge action

Posted by pp on October 19, 2008 at 3:27pm

Issue Summary

It is a bug report, not a feature request.

First of all: The system_mail function includes some taxonomy variables but the action settings form's description does not present these. (%term_name, %term_description, %term_id, %vocabulary_name, %vocabulary_description, %vocabulary_id) These are the hidden variables.

Next: The system_send_email_action function gives the comment's data(in the context) but doesn't use it(just the cid, to load the node). It's a bug. When I make a trigger for new comment, I can't make informative email which contains the comment data. I just make a simple message which contains node data. When anybody comments my blog I read 'You got a new comment'. This is unusable! I want to make a more informative mail that contains the comment body itself. Drupal 6 has this feature but I can't use it because the system module has this bug.

System message is the same.

Attachment	Size	Status	Test result	Operations
hidden_or_missing_variables_system.module.patch	3.86 KB	Idle	FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch hidden_or_missing_variables_system.module_0.patch.	View details \| Re-test

Comments

#1

Posted by Gábor Hojtsy on October 19, 2008 at 5:22pm

#2

Posted by Gábor Hojtsy on October 19, 2008 at 5:23pm

BTW this was broken off from http://drupal.org/node/287315#comment-1066369 but I am not entirely sure that it is indeed a different issue. Or at least only part of it is.

#3

Posted by earnie on October 19, 2008 at 8:45pm

Status:

needs review

» needs work

Right. This patch should not contain the portion of code from the feature request; it should contain only the bug fix. Remove the additional %comment* from the patch.

#4

Posted by Artem on October 26, 2008 at 7:21pm

Subscribing

#5

Posted by bwooster47 on January 19, 2009 at 1:32am

My vote is for patching this as is. The current available action is pretty meaningless for sending emails on comments if the email cannot include any info about the subject or body of the comment. No point in having an email action at all for comments in this case.
Oh well....

#6

Posted by pp on March 30, 2009 at 6:26pm

Here is a little module which resolve this problem.

Attachment	Size	Status	Test result	Operations
comment_action_mail.zip	958 bytes	Ignored	None	None

#7

Posted by mikeybusiness on May 31, 2009 at 9:19pm

Can we get this patch added to 6.x? Clearly the non working variables need to be fixed.

As far as the fix containing the addition of the comment variables. I feel like they are an implementation of features already part of D6.

#8

Posted by pp on June 1, 2009 at 6:16am

Status:

needs work

» needs review

Here is a patch which show hidden variables. If you like use comment data use the modul in the #6.

Attachment	Size	Status	Test result	Operations
323325-2.patch	1.07 KB	Idle	FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 323325-2.patch.	View details \| Re-test

#9

Posted by pp on June 1, 2009 at 7:26am

Title:	Hidden or missing variables in the system's send email and messge action	» Hidden variables in the system's send email and messge action
Version:	6.x-dev	» 7.x-dev

Ok... i thought. I suggest let's separated the two problem, hidden and missing(comment) variables.

Here is a patch for 7x and #8 for 6x. Please review.