While executing update.php (Update #6104):

user warning: Duplicate column name 'show_citation' query: ALTER TABLE quotes_blocks ADD `show_citation` SMALLINT DEFAULT 0 in /Users/simonroberts/src/projects/eightyoptions/tafa/tafa.65/includes/database.mysql-common.inc on line 298.
user warning: Duplicate column name 'max_length' query: ALTER TABLE quotes_blocks ADD `max_length` INT NOT NULL DEFAULT 0 in /Users/simonroberts/src/projects/eightyoptions/tafa/tafa.65/includes/database.mysql-common.inc on line 298.
user warning: Duplicate column name 'view_weight' query: ALTER TABLE quotes_blocks ADD `view_weight` SMALLINT DEFAULT 1 in /Users/simonroberts/src/projects/eightyoptions/tafa/tafa.65/includes/database.mysql-common.inc on line 298.
user warning: Duplicate column name 'more_text' query: ALTER TABLE quotes_blocks ADD `more_text` VARCHAR(64) DEFAULT NULL in /Users/simonroberts/src/projects/eightyoptions/tafa/tafa.65/includes/database.mysql-common.inc on line 298.
user warning: Duplicate column name 'view_text' query: ALTER TABLE quotes_blocks ADD `view_text` VARCHAR(64) DEFAULT NULL in /Users/simonroberts/src/projects/eightyoptions/tafa/tafa.65/includes/database.mysql-common.inc on line 298.

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Hmm... I think you can safely ignore the messages.

Can you explain the upgrade process you used, particularly the Quotes part? Did you disable Quotes on the 5.x system before upgrading, as recommended?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Postponed (maintainer needs more info)
lyricnz’s picture

lyricnz commented

Yes, of course. I'll be doing this upgrade process again soon (this was a trial run, for a live site), so will pay more attention to this issue next time.

lyricnz’s picture

lyricnz commented

Sorry, client decided not to proceed with the project (well, they decided that my pre-sales demo was good enough, and didn't need any more work), so I won't have the chance to run through this upgrade again. Feel free to close, or leave.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

Okay

pbuyle’s picture

pbuyle commented
Version: 6.x-1.2 » 6.x-1.40
Status: Closed (fixed) » Active

I ran into the same issue while upgrading from D5 to D6. And I think I've found its source.

In quotes_update_9 (from 5.x-1.91), the columns are added to the {quotes_blocks} table. In quotes_update_6104 (from 6.x-1.40), the same columns are also added. While the other quotes_update_6xxx functions check for the corresponding 5.x updates before altering the database schema, quotes_update_6104 does not.

In quotes_update_6104, the five calls to db_add_field should be wrapped in an if block like it's done for the count column in quotes_update_6101. A single column check can be used since the 5 columns are all added in quotes_update_9.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Fixed

Committed to 6.x-1.x-dev. Unable to test.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.