Hi, first of all, this is a very great piece of module.

I'm using Drupal 4.6.3 and Postgresql 7.4.8. So I changed some sql statements in these code to have better support on pgsql. Basically..more on removing DISTINCT, change all the double quotes in sql statement to single quotes...so it shouldn't have big affect on the code itself.

Here's the problem I have...

I set up two access group say Manager and Normalstaff. When I edit/compose a page, and say selected Manager is the only group to view this page via the UI box, then clicking "Preview" to see this page, the simple access selection box will reset and unchecked all the selections...in this case, Manager is now unchecked...so this document will be viewable by everyone.

The current workaround solution is to re-check Manager in the preview page and submit. So one needs to reselect the access rights before the actual submittion.

I hope anyone else will share the same problem as me...so it's not my own problem.

Thx.

Wilson

CommentFileSizeAuthor
#5 simple_access.patch5.98 KBbwynants
#4 simple_access.module25.23 KBbwynants

Comments

wilsonchow’s picture

wilsonchow commented

I just test with the latest cvs version of 4.6.x. And the same version I use 1.15 of simple_access.module....still behave the same. Any idea on how to fix this annoying bug?

bwynants’s picture

bwynants commented

just reproduced this as well......

gjost’s picture

gjost commented
Title: All selections unchecked when I preview the page. » Is this a general form_* problem?

I found this post while trying to find an answer to a problem with a custom module i'm writing. I have several form_select elements where the values get lost when previewing. Maybe this is a general problem with form elements?

bwynants’s picture

bwynants commented
Status: Active » Needs review
StatusFileSize
new simple_access.module25.23 KB

Fixed this and also added defaults for every node type based on http://drupal.org/node/30997

bwynants’s picture

bwynants commented
StatusFileSize
new simple_access.patch5.98 KB

oops included full module and not patch :-)

jjeff’s picture

jjeff commented

Thanks for the patch!

I'll take a look at this as soon as I get a chance.

-Jeff

bwynants’s picture

bwynants commented
Status: Needs review » Needs work

Is wrong if nothing was selected as default (for edit or delete) for a user that has no access to the checkboxes. I need to look into that! (see http://drupal.org/node/43068)

bwynants’s picture

bwynants commented
Status: Needs work » Needs review

Since simple_access_node_grants never returns 0 = all for update and delete the patch is correct

suggest to also commit/rework it also for CVS

gordon’s picture

gordon commented
Status: Needs review » Fixed

I think this issue is now fixed in 4.7 and above.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)