Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The tab key after typing the password skips straight to 'login', missing the checkbox for persistent login. Perhaps that can be fixed?
Comments
Comment #1
bjaspan commentedWhich web browser and OS? Tabbing goes to the checkbox for me on FF3/Mac and Safari/Mac.
Comment #2
Flying Drupalist commentedIt occurs on Opera/FF/Chrome in Vista. Though my problem might have to do with the fact that I'm using it in a LoginToboggan javascript box?
Comment #3
markus_petrux commentedMaybe related to tabindex. Maybe it should be set based on what's present in existing form fields, which may happen if someone else altered the login form before the hook reaches the PL module. ¿?
Comment #4
markus_petrux commentedOne possible way to address this would to dynamically set the tabindex of the remember me checkbox. However, this will have a dependency on the order of modules are loaded/executed. So ideas are welcome.
Comment #5
markus_petrux commentedComment #6
markus_petrux commentedWell, I have committed a change to the hook_form_alter() that deals with the login form to should fix this issue. You can try the code from the latest 6.x-1.x-dev snapshot that should be available soon, probably on midnight. Or checking out from CVS.
Explanation: the new hook_form_alter() implementation in PL now just adds the "Remember me" checkbox, but also adds an after_build callback. This one is executed by FAPI after all modules have altered the form, and here we can now adjust the weight and tabindex attributes of the "Remember me" checkbox so that it is always one element before the submit button.
Please, feel free to re-open if it doesn't work as expected. ;-)
Comment #7
markus_petrux commentedBTW, the particular commit that implements this fix can be found here:
http://drupal.org/cvs?commit=202538
Comment #8
markus_petrux commentedThis fix should also be available in the BETA5 package.