Comments

Crell’s picture

I don't think this will cause any issues, but I thought some other test modules used the _test format. I don't care much either way. However, there are a lot of test-modifying patches in the queue right now. Let's not do this until those get in, so we don't have to reroll them. :-)

Crell’s picture

Uh, Dries: http://drupal.org/node/306224#comment-1078144

So which is it, _test or no? I went with _test originally exactly because other modules were doing so.

alexanderpas’s picture

afaik it's thing.test and thing_test.module

this removes the _test.test duplication

Crell’s picture

Well, if we want to do it, only the CVS admins can do so. It can't be done via a patch. Dries, your call. The file should be reasonably stable right now, although there's still some patches pending that would apply to it.

berdir’s picture

Version: 7.x-dev » 8.x-dev

What about postponing this to 8.x-dev and do this nicely with git? :)

Crell’s picture

I am perfectly OK with that approach. :-)

pillarsdotnet’s picture

Status: Active » Needs review
StatusFileSize
new1.07 KB

Patch.

Crell’s picture

Status: Needs review » Reviewed & tested by the community

Git for the win.

pillarsdotnet’s picture

Category: bug » task
droplet’s picture

Status: Reviewed & tested by the community » Needs work

not just rename the file.
need to change the code, eg.

files[] = tests/database_test.test

pillarsdotnet’s picture

pillarsdotnet’s picture

Status: Needs work » Needs review
Crell’s picture

Title: Rename database_test.test to database.test for consistency » Rename database_test.test and entity_crud_test.test for consistency
Status: Needs review » Reviewed & tested by the community

Crell for the lose. *sigh*

Silly testbot not catching that it isn't recognizing a test...

catch’s picture

xjm’s picture

Tagging issues not yet using summary template.

klausi’s picture

Status: Reviewed & tested by the community » Needs work

does not apply anymore

pillarsdotnet’s picture

Title: Rename database_test.test and entity_crud_test.test for consistency » Rename database_test.test to database.test for consistency
Status: Needs work » Needs review
StatusFileSize
new2.18 KB
new939 bytes

Since entity was moved to its own module, any renamings there should be in a separate issue.

Re-rolled patch (only) renames database_test to database.test but now I question the "consistency" of the change.

Before:
$ find includes modules | grep database.test
modules/simpletest/tests/database_test.info
modules/simpletest/tests/database_test.test
modules/simpletest/tests/database_test.module
modules/simpletest/tests/database_test.install
After:
$ find includes modules | grep database.test
modules/simpletest/tests/database_test.info
modules/simpletest/tests/database.test
modules/simpletest/tests/database_test.module
modules/simpletest/tests/database_test.install

At any rate, the invalid references to the entity tests should be removed from simpletest.info

Splitting the patch into two parts. At least part one should be committed; part two is debatable.

Crell’s picture

berdir’s picture

Status: Needs work » Closed (duplicate)

Did the rename as part of #1558268: Database tests are not available.

The remarks in #17 have been fixed, the entity stuff was removed from simpletest.info during the test move and the database.test file is now in a different directory than the database_test module anyway.