Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I don't think this will cause any issues, but I thought some other test modules used the _test format. I don't care much either way. However, there are a lot of test-modifying patches in the queue right now. Let's not do this until those get in, so we don't have to reroll them. :-)
Well, if we want to do it, only the CVS admins can do so. It can't be done via a patch. Dries, your call. The file should be reasonably stable right now, although there's still some patches pending that would apply to it.
The remarks in #17 have been fixed, the entity stuff was removed from simpletest.info during the test move and the database.test file is now in a different directory than the database_test module anyway.
Comments
Comment #1
Crell commentedI don't think this will cause any issues, but I thought some other test modules used the _test format. I don't care much either way. However, there are a lot of test-modifying patches in the queue right now. Let's not do this until those get in, so we don't have to reroll them. :-)
Comment #2
Crell commentedUh, Dries: http://drupal.org/node/306224#comment-1078144
So which is it, _test or no? I went with _test originally exactly because other modules were doing so.
Comment #3
alexanderpas commentedafaik it's thing.test and thing_test.module
this removes the _test.test duplication
Comment #4
Crell commentedWell, if we want to do it, only the CVS admins can do so. It can't be done via a patch. Dries, your call. The file should be reasonably stable right now, although there's still some patches pending that would apply to it.
Comment #5
berdirWhat about postponing this to 8.x-dev and do this nicely with git? :)
Comment #6
Crell commentedI am perfectly OK with that approach. :-)
Comment #7
pillarsdotnet commentedPatch.
Comment #8
Crell commentedGit for the win.
Comment #9
pillarsdotnet commentedComment #10
droplet commentednot just rename the file.
need to change the code, eg.
files[] = tests/database_test.test
Comment #11
pillarsdotnet commentedCorrected.
Comment #12
pillarsdotnet commentedComment #13
Crell commentedCrell for the lose. *sigh*
Silly testbot not catching that it isn't recognizing a test...
Comment #14
catch#11: simpletest_rename_test.test_.test_for_consistency-323802-11.patch queued for re-testing.
Comment #15
xjmTagging issues not yet using summary template.
Comment #16
klausidoes not apply anymore
Comment #17
pillarsdotnet commentedSince entity was moved to its own module, any renamings there should be in a separate issue.
Re-rolled patch (only) renames
database_testtodatabase.testbut now I question the "consistency" of the change.At any rate, the invalid references to the entity tests should be removed from
simpletest.infoSplitting the patch into two parts. At least part one should be committed; part two is debatable.
Comment #18
Crell commentedThis was just broken by #1299424: Allow one module per directory and move system tests to core/modules/system. Maybe merge into #1558268: Database tests are not available?
Comment #19
berdirDid the rename as part of #1558268: Database tests are not available.
The remarks in #17 have been fixed, the entity stuff was removed from simpletest.info during the test move and the database.test file is now in a different directory than the database_test module anyway.