Would it be possible to make RealName working with Submitted By so that Submitted By does not eliminate the effects of RealName?

Comments

lomz’s picture

nancydru’s picture

Assigned: Unassigned » nancydru
Status: Active » Fixed

That tokens file I just added should take care of you. Please test it after it rolls up so I can make a new official release.

lomz’s picture

I am already testing it, thats why I filed these issues.

lomz’s picture

Just checked the list of tokens I could choose from in Submitted By and compared to the list of tokens in token_realname.inc, the new tokens do not appear, not even after I cleared the cache.

nancydru’s picture

[realname] => The RealName for the user.
[realname-link] => Themed username link.
[homepage] => The home page for the user.

I did just make a small tweak after testing this with the Submitted_by module.

lomz’s picture

The I test it it and see

nancydru’s picture

BTW, Submitted_by has been updated too.

lomz’s picture

When trying to use realname with submittet by comments with this line

Skrevet av [realname-link], den [dd]/[mm]/[yyyy]

The name of the author of the comments switched with the realname-link of the author of the blogpost the comment was linked to.

nancydru’s picture

Hmm, this is going to be interesting to see which one is doing this.

lomz’s picture

My quess is that it is submitted by, I get the same error trying without realname #297689: Comments

nancydru’s picture

Fix committed. It was a little of both. I'm still learning Token.

lomz’s picture

W are almost there, now it uses the hompepage to the first of the registered users to give homepage to all the unregistered users, if no registered users has commented it collects url from the blogpostauthor.

I think there is a need for a unique set of tokens for comments and one set for posts

lomz’s picture

Additional info:
Tried this in the sumitted y-field for comments:

Skrevet av <a href="[homepage]">[comment-author-name-raw]</a>, den [comment-dd]/[comment-mm]/[comment-yyyy]

Since [comment-author-name-raw] in it self doesnt provide a link in it self.

nancydru’s picture

Just curious, why not [realname-link]?

lomz’s picture

I am not sure, but there must be a reason tht they created a lot of tokens with comment- as prefix.

nancydru’s picture

I think it was just to separate them. But the tokens-value hook gets called by content type (e.g, 'node' or 'comment') so I didn't change the name. But they should be distinct.

lomz’s picture

I'll test the new release

lomz’s picture

Still the same, could you add comment- in front of the token for comments?

nancydru’s picture

Status: Fixed » Active

I'll try.

nancydru’s picture

Okay, done. The names are [comment-xxx] or [user-xxx] now.

lomz’s picture

We are almost there, now it seems to work for the unregistered users, except for that the link just shows for the first comment by a unregistered user.

This is tricky

Good news is that the last fix fixed the issue #324804: Users without homepage gets homepage as well.

lomz’s picture

Now I tested without submitted by, and it appears that without submitted by all the unregistered users now get ALL theyre links but the registered users without webpages get the homepage of the 1 user.

nancydru’s picture

Status: Active » Postponed (maintainer needs more info)

Okay, I need some help recreating this because it's working for me.

lomz’s picture

Strange, can I see the page you have where it works, with (not verified) for the non-registereds?

What can I do more than just cleaning the cache?

Do you want to see my webpage? With (not verified)?

nancydru’s picture

Oh, all mine are real users.

lomz’s picture

Examplesites:
http://vindstille.net/christian/er-studentene-for-sentrumskravstore
http://vindstille.net/christian/178-mil-senere
http://vindstille.net/siri/blå-kors-og-maslow

Most of theese users with () after is with homepages.
Just tell me what more you need or something I can do.

nancydru’s picture

Okay, I understand now. I think there are actually two problems here. 1) I think my code does need some improvement for comments. 2) The token module should be building the user's homepage for anonymous users and I just looked and it does not (#325227: Provide e-mail and commenter homepage tokens for comments).

I will have to continue this tomorrow.

nancydru’s picture

Status: Postponed (maintainer needs more info) » Fixed

Between this fix and the token_comment.inc patch, you should be in business.

For my node I use Contributed on [month] [d], [yyyy] by [realname-link].
For my comments I use Comment by [comment-homepage-link] on [comment-month] [comment-d], [comment-yyyy]

lomz’s picture

Just a tip, with that setting and if a user do not leave homepage they will be left without name.

nancydru’s picture

I made a small change to the token_comment.inc for that problem.

lomz’s picture

I added that to, but still the same problem with that token, but this is with unregistered users who do not leave a homepage.

nancydru’s picture

Status: Fixed » Active

I will get back to this soon.

lomz’s picture

thanks

nancydru’s picture

Status: Active » Fixed

I am no longer seeing this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

itaine’s picture

[realname-link] isn't working for me with "submitted by", I'm using realname-6.x-1.1 and the latest version of "submitted by". Which token should I use?

nancydru’s picture

Please open this as a new support request.