Hi, I've already filed this as an Issue under Colophon but thought it might be worth listing here also since the error code I see indicates that the problem might be in the Panels Info file. . .

I get the following error when accessing the Colophon page on my site. . .

warning: Error parsing sites/all/modules/panels/panels_views/panels_views.info on line 3 in C:\wamp\www\sites\all\modules\colophon\colophon.module on line 236.

I'm not sure if this is a Colophon problem or a Panels problem, since I'm not PHP literate. . .

I'm not sure if I should be cross posting this, sorry if I'm stepping on any toes. . .

Thanks for a great module. I'm new to Drupal and Panels (when the full release comes out) will be one of the things that make the whole package ROCK for me!

CommentFileSizeAuthor
#2 panels_323895.patch4.28 KBdrewish

Comments

austintnacious’s picture

austintnacious commented
Title: Potential problem working with Colophon » colophon.module vs. panels_views.info

Actually so I just looked at the files referenced in the error message and it seems to me like colophon.module has a problem with the parentheses in panels_views.info

Line 3
description = Integrates Views as Panel panes (content types).

If I remove "(content types)" from that line and run Colophon again the error goes away.

So I don't know if this points to a problem with colophon.module or the use of illegal / inappropriate characters in panels_views.info

I'll copy this comment to the issue I created for Colophon and whoever needs to fix it can do so whenever. . .

Thanks again!

drewish’s picture

drewish commented
Status: Active » Needs review
StatusFileSize
new panels_323895.patch4.28 KB

The description needs to be quoted. This patch quotes all the descriptions in case someone decides to add wacky characters to them later on.

merlinofchaos’s picture

merlinofchaos commented

I'm not sure I agree with drewish. If Drupal's parser parsers it, then I don't agree that some contrib module should tell me that my strings have to be quoted when Drupal doesn't make me quote them. That's the contrib module failing to parse correctly.

-1 this patch.

drewish’s picture

drewish commented

merlin, i'm guessing Colophon is using php's parse_ini_file() which provides the following note:

Note: If a value in the ini file contains any non-alphanumeric characters it needs to be enclosed in double-quotes (").

Drupal core uses drupal_parse_info_file() which seems more flexible in it's handling of strings.

drewish’s picture

drewish commented

though there's also something to be said for either following the documentation or fixing it...

merlinofchaos’s picture

merlinofchaos commented

If it's using parse_ini_file() then it will have problems anyway, as parse_ini_file() can't handle the [] syntax that Steven added.

drewish’s picture

drewish commented
Project: Panels » Colophon
Version: 6.x-2.0-alpha2 » 6.x-1.x-dev
Component: Miscellaneous » Code

then lets bump it over.

Max_Headroom’s picture

Max_Headroom commented
Status: Needs review » Fixed

Fixed as per #4. Please test dev.
Thanks

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.