When I wrote the patch against farbtastic.js to make it work with jQuery 1.2.6 the solution was sloppy. It added a hack onto the existing code to get the coordinates in the function fb.widgetCoords rather than taking advantage of what was in jQuery. The attached patch is a cleaner, faster, and smaller (2 lines) to accomplish the same thing.

I tested this in FF3 (mac and pc), Safari and Webkit (mac), and IE (6/7 on pc).

CommentFileSizeAuthor
farbtastic_update_jquery_1.2.6.patch2.01 KBmfer

Comments

mfer’s picture

mfer commented

To test this patch apply it and see if the color picker works in the different major browsers. It's as easy as that.

mfer’s picture

mfer commented

I, also, tested in Google Chrome.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community

Yup!

For those interested, this is the path to get rid of the unmaintained Farbtastic:

  1. #315797: JavaScript Patch #1: $options
  2. #315100: Allow to add JS/CSS libraries (sets of files, settings, and dependent libraries)
  3. #315035: Add jQuery UI elements to core
mfer’s picture

mfer commented

FYI, jQuery UI has a color picker as part of the package.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.