problem with matching "is all of" on an allowed values list, if allowed values contain spaces, dashes, etc.

Well, this one should be easy to replicate :-) i have checked the queue and nobody seems to have reported this yet, my apologies if there is already an issue open for this.

1) create a CCK text field with a list of "allowed values", where some are just words, but others contain spaces or dashes

2) create a View with an exposed filter on that field, and tell it to do an "is all of" matching.

3) in the view preview, try to match on one or more values that are single words. no problem. now, try matching on one or more where at least one contains a space or dash. you will get an SQL error something like the following:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-Dynamics ON node.vid = node_data_field_host_features_Bio-Dynamics.vid AND node_' at line 12 query: SELECT node.nid AS nid, node.title AS node_title, node_data_field_host_picture_1.field_host_picture_1_fid AS node_data_field_host_picture_1_field_host_picture_1_fid, node_data_field_host_picture_1.field_host_picture_1_list AS node_data_field_host_picture_1_field_host_picture_1_list, node_data_field_host_picture_1.field_host_picture_1_data AS node_data_field_host_picture_1_field_host_picture_1_data, node_data_field_host_picture_1.nid AS node_data_field_host_picture_1_nid, node.type AS node_type, node_data_field_host_picture_1.field_host_email_1_value AS node_data_field_host_picture_1_field_host_email_1_value, node.vid AS node_vid, node_data_field_host_picture_1.field_host_website_value AS node_data_field_host_picture_1_field_host_website_value FROM node node INNER JOIN content_field_host_features node_data_field_host_features_Bio-Dynamics ON node.vid = node_data_field_host_features_Bio-Dynamics.vid AND node_data_field_host_features_Bio-Dynamics.field_host_features_value = 'Bio-Dynamics' INNER JOIN content_field_host_features node_data_field_host_features_culinary herbs ON node.vid = node_data_field_host_features_culinary herbs.vid AND node_data_field_host_features_culinary herbs.field_host_features_value = 'culinary herbs' LEFT JOIN content_type_profile_host node_data_field_host_picture_1 ON node.vid = node_data_field_host_picture_1.vid WHERE (node.type in ('profile_host')) AND (node_data_field_host_features_Bio-Dynamics.field_host_features_value = 'Bio-Dynamics' AND node_data_field_host_features_culinary herbs.field_host_features_value = 'culinary herbs') LIMIT 0, 10 in /home/www/wwoof.ca/htdocs/sites/all/modules/views/includes/view.inc on line 723.

seems pretty obvious to me what is happening here... the values "Bio-Dynamics" and "culinary herbs" don't cause problems when they are in single quotes (eg: "field_host_features_value = 'Bio-Dynamics' ") but when they are used to create temporary table aliases (eg: "JOIN content_field_host_features node_data_field_host_features_Bio-Dynamics ON node.vid = node_data_field_host_features_Bio-Dynamics.vid") they should have their spaces, dashes etc. converted to underscores first!

i hope this can be fixed quickly!