When hovering over a block generated by Views 2, an "edit view" link appears on top-right corner. It uses URL building pattern for Views 1. in views two, blocks are being defined as new displays, and edit links have a different format. I've took a look into Views 2 theming files, but so far could not find a way to rewrite function zen_preprocess_block() in such a way that it will detect view name and view display name/url.

CommentFileSizeAuthor
#5 zen-views-block-link.patch1.17 KBjohnalbin
#2 zen_edit_view.diff915 bytesdalin

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Priority: Normal » Critical

Good point! Thanks for the heads up.

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Priority: Critical » Normal
Status: Active » Needs review
StatusFileSize
new zen_edit_view.diff915 bytes

It's a simple fix.

yoroy’s picture

yoroy commented

Gentle bump from a non-coding non-patch applier. ZenViews love FTW.

jurriaanroelofs’s picture

jurriaanroelofs commented

tested and confirmed to work. thx.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Block edit link "edit view" not properly formatted for Views 2 » Broken block editing link for Views 2
Status: Needs review » Fixed
StatusFileSize
new zen-views-block-link.patch1.17 KB

Turns out the patch work when the view has multiple blocks in it. Here's the corrected patch that I committed. http://drupal.org/cvs?commit=168507

Thanks for the bug report, patch, and review! I love it!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.