Missing index on uid [#324110]

Comment	File	Size	Author
#7	dblog_index_324110.patch	951 bytes	mikeryan
	dblog_add_index.patch	895 bytes	killes@www.drop.org

Comment #1

Anonymous (not verified) commented 21 October 2008 at 12:02

Status:

Needs review

» Reviewed & tested by the community

An index on uid has other uses as well, such as a filter by uid.

Log in or register to post comments

Comment #2

dries commented 22 October 2008 at 18:33

Status:

Reviewed & tested by the community

» Fixed

I fixed the tab-issue and committed this to CVS HEAD. It will need to be re-rolled for Drupal 6 (i.e. update function) so for now I'm marking this 'fixed'. Thanks killes -- glad to see you're submitting patches again!

Log in or register to post comments

Comment #3

killes@www.drop.org commented 24 October 2008 at 13:53

Version:	7.x-dev	» 6.x-dev
Status:	Fixed	» Needs review

Oh my, I submit a patch and it has a tab. I really should do this more often to practise. ;)

Goba, do you want this in D6? If not, change back status.

Log in or register to post comments

Comment #4

killes@www.drop.org commented 24 November 2008 at 10:14

Version:

6.x-dev

» 7.x-dev

I later remembered why there wasn't an index on uid (and timestamp): We deliberately omitted it as we thought that the inserts would be slow if the index would also need to be updated.

However, we already added an index for the type column in http://drupal.org/node/99128

Also, the missing indices seem to be a problem on drupal.org, see http://drupal.org/node/165061

Thus I propose we keep it as it is and also add an index on the timestamp column. If you log enough that the index updates are a problem for you, you should be looking for alternate means of logging.