Not all discounts are time-based.
Eg, particular role gets a 10% discount on the site.

Should we add a "Permanent" checkbox?
For the time being, an acceptable workaround is to set expiry to 2050 ... :)

Comments

psynaptic’s picture

psynaptic commented

Apparently, dates can be a pain in PHP. One other issue in this queue is about setting a date past 18th January 2038. The data widget seems to provide the date widget so this should likely be posted against FAPI if anything.

Time doesn't seem like it should by default apply to most discounts. It is more of a condition. I think we should try to abstract the date stuff into a separate condition module.

joachim’s picture

joachim commented
Title: Allow permanent discounts » Move discount date settings out to a condition
Category: feature » task

Agreed. Updating title.

psynaptic’s picture

psynaptic commented
Status: Active » Closed (duplicate)

Accidentally created a duplicate issue for this but since it describes this cleanly I'm going to mark this as duplicate to #329109.